sync: fix a memory leak when header verification fails #8431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battlmonstr
force-pushed
the
pr/mumbai_mem_prof
branch
from
ab3dd2f
to
0e66c35
Compare
mh0lt
approved these changes
Oct 13, 2023
wmitsuda
pushed a commit
that referenced
this pull request
Oct 17, 2023
If HeaderDownload.VerifyHeader always returns false, the memory usage grows at a fast pace due to Link objects (containing headers) not deallocated even after the link queue pruning.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If HeaderDownload.VerifyHeader always returns false, the memory usage grows at a fast pace
due to Link objects (containing headers) not deallocated even after the link queue pruning.