Txpool: db unlimited grow fix #8596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
force-pushed
the
txpool_db_grow
branch
from
2479b40
to
ac28dcf
Compare
yperbasis
reviewed
Oct 27, 2023
| } | ||
| return nil |
There was a problem hiding this comment.
This line + 3 lines above could be simplified to return err
yperbasis
reviewed
Oct 27, 2023
| } | ||
| } else { | ||
| unwindTxs.Append(utx, sender, false) | ||
| continue |
There was a problem hiding this comment.
To my mind the previous version with if change.Direction == remote.Direction_UNWIND was clearer
yperbasis
approved these changes
Oct 27, 2023
yperbasis
added a commit
that referenced
this pull request
Oct 29, 2023
read transaction was opened before stream.Recv(), but stream.Recv() is blocking infinity loop. so, this read transaction never rollback - causing unlimited db grow. --------- Co-authored-by: Andrew Ashikhmin <34320705+yperbasis@users.noreply.github.com>
yperbasis
added a commit
that referenced
this pull request
Oct 29, 2023
read transaction was opened before stream.Recv(), but stream.Recv() is blocking infinity loop. so, this read transaction never rollback - causing unlimited db grow. --------- Merge PR #8596 into `devel` --------- Co-authored-by: Alex Sharov <AskAlexSharov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read transaction was opened before stream.Recv(), but stream.Recv() is blocking infinity loop. so, this read transaction never rollback - causing unlimited db grow.