Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to release non-breaking BEM-supported 2.0? #48

Closed
leslc opened this issue Nov 13, 2017 · 2 comments
Closed

Possible to release non-breaking BEM-supported 2.0? #48

leslc opened this issue Nov 13, 2017 · 2 comments
Labels

Comments

@leslc
Copy link

leslc commented Nov 13, 2017

Hi @leejordan,

Thanks for sharing the reflex grid. Our project has benefited immensely from it. We want to upgrade to 2.0 but there are too many pages to regression to change the HTML.

I know you have thought over the BEM naming issue a bit. As some people have requested backward compatible version as well, would you entertain publishing an older version (e.g. v1.9) that has your 2.0 improvements with old BEM naming?

I understand that "support" isn't necessarily what you're doing this for. :) I'd be happy to work on this (with a few pointers, e.g. is "_grid.scss" the only place to change the naming of "col" --> "grid__col"?)

Thanks!

@miketdonahue
Copy link

My project would also be interested in backward compatibility if possible 👍

@leejordan
Copy link
Owner

I'm not sure if I can spare the time to do this but it certainly is possible to find/replace all the class names then build your own version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants