Skip to content
This repository has been archived by the owner on Dec 26, 2023. It is now read-only.

ARM64 support is broken #311

Closed
pat-s opened this issue Feb 21, 2023 · 4 comments · Fixed by #562, #561 or #568
Closed

ARM64 support is broken #311

pat-s opened this issue Feb 21, 2023 · 4 comments · Fixed by #562, #561 or #568

Comments

@pat-s
Copy link
Contributor

pat-s commented Feb 21, 2023

Longterm it would be great to be able to run OTF on arm64 arch - saves some bucks :) Any immediate plans for a multi-arch image?

@leg100
Copy link
Owner

leg100 commented Feb 21, 2023

arm64 on mac or linux, or both?

@pat-s
Copy link
Contributor Author

pat-s commented Feb 21, 2023

Ah, on Linux!

@leg100
Copy link
Owner

leg100 commented Feb 22, 2023

OK, I've noticed as well that the terraform downloader assumes the amd64 architecture:

https://github.com/leg100/otf/blob/master/agent/downloader.go#L75

That'll need fixing. To get OTF running on arm64 other fixes might be needed but we won't know until we test. As it is, I'll rename this issue to reflect that arm64 support is broken. I don't have an arm64 arch to test on. Once I've made fixes, are you able to test?

@leg100 leg100 changed the title arm64 images? ARM64 support is broken Feb 22, 2023
@pat-s
Copy link
Contributor Author

pat-s commented Feb 23, 2023

Once I've made fixes, are you able to test?

jup. Even though I am currently running OTF in an AWS region without arm64, I can test in another one 👍

leg100 pushed a commit that referenced this issue May 31, 2023
Tested via a custom image.

The only issue I encountered is that the footer version was reported as
"unknown" but that might be due to other changes in the image building
process of mine and unrelated to this one.

Not sure if the solution is elegant, I am a beginner in GO and was just
happy to get it working. Feel free to tweak to your liking!

#311
leg100 added a commit that referenced this issue Aug 5, 2023
Adds everything necessary to not only ensure OTF runs on linux/arm64 but
can be tested on linux/arm64 too.

Fixes #311
leg100 pushed a commit that referenced this issue Aug 13, 2023
🤖 I have created a release *beep* *boop*
---


## [0.1.8](v0.1.7...v0.1.8)
(2023-08-13)


### Features

* allow terraform apply on connected workspace
([#564](#564))
([6f90a9c](6f90a9c)),
closes [#231](#231)
* **ui:** add icon in run widget to show source of run
([#563](#563))
([2e7a0bd](2e7a0bd))


### Bug Fixes

* cleanup after extracting repo tarball
([bf4758b](bf4758b))
* don't scrub included state output sensitive values
([478e314](478e314))
* linux/arm64 support ([#562](#562))
([01a2112](01a2112)),
closes [#311](#311)
* otfd compose healthcheck: curl not installed
([9f52021](9f52021))
* retry run should use existing run properties
([49303ec](49303ec))
* **tests:** hard link fails when /tmp is separate partition
([cfc7aaa](cfc7aaa))
* **ui:** workspace description missing after update
([a579b40](a579b40))
* use png instead of svg for font-based icons
([eae0588](eae0588))


### Miscellaneous

* bump squid version
([7ce3238](7ce3238))
* go 1.21 ([#566](#566))
([06c13b2](06c13b2))
* remove unused cloud team and org sync code
([4e1817d](4e1817d))
* removed unused ca.pem
([799ed25](799ed25))
* skip api tests if env vars not present
([5b88474](5b88474))
* **ui:** make tags less bulbous
([df1645d](df1645d))
* **ui:** pad out buttons on consent page
([1c290e9](1c290e9))
* update docs
([364d183](364d183))
* validate resource names
([c7596fe](c7596fe))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
leg100 pushed a commit that referenced this issue Aug 13, 2023
🤖 I have created a release *beep* *boop*
---


## [0.1.8](v0.1.7...v0.1.8)
(2023-08-13)


### Features

* allow terraform apply on connected workspace
([#564](#564))
([6f90a9c](6f90a9c)),
closes [#231](#231)
* **ui:** add icon in run widget to show source of run
([#563](#563))
([2e7a0bd](2e7a0bd))


### Bug Fixes

* cleanup after extracting repo tarball
([bf4758b](bf4758b))
* don't scrub included state output sensitive values
([478e314](478e314))
* linux/arm64 support ([#562](#562))
([01a2112](01a2112)),
closes [#311](#311)
* otfd compose healthcheck: curl not installed
([9f52021](9f52021))
* qemu needed for building multi-arch images
([1aa8cf8](1aa8cf8))
* retry run should use existing run properties
([49303ec](49303ec))
* **tests:** hard link fails when /tmp is separate partition
([cfc7aaa](cfc7aaa))
* **ui:** workspace description missing after update
([a579b40](a579b40))
* use png instead of svg for font-based icons
([eae0588](eae0588))


### Miscellaneous

* bump squid version
([7ce3238](7ce3238))
* go 1.21 ([#566](#566))
([06c13b2](06c13b2))
* **master:** release 0.1.8
([#561](#561))
([9c6d0f6](9c6d0f6))
* remove unused cloud team and org sync code
([4e1817d](4e1817d))
* removed unused ca.pem
([799ed25](799ed25))
* skip api tests if env vars not present
([5b88474](5b88474))
* **ui:** make tags less bulbous
([df1645d](df1645d))
* **ui:** pad out buttons on consent page
([1c290e9](1c290e9))
* update docs
([364d183](364d183))
* validate resource names
([c7596fe](c7596fe))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants