Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit CLI apply on connected workspace #231

Closed
leg100 opened this issue Nov 20, 2022 · 4 comments · Fixed by #564, #561 or #568
Closed

Permit CLI apply on connected workspace #231

leg100 opened this issue Nov 20, 2022 · 4 comments · Fixed by #564, #561 or #568

Comments

@leg100
Copy link
Owner

leg100 commented Nov 20, 2022

OTF should replicate TFC behaviour of prohibiting an apply via the CLI on a workspace connected to a VCS repo, reporting an error like so:

> terraform apply
╷
│ Error: Apply not allowed for workspaces with a VCS connection
│
│ A workspace that is connected to a VCS requires the VCS-driven workflow to ensure that the VCS remains the single source of truth.
╵
@fsaintjacques
Copy link
Contributor

If implemented, add a toggle in the workspace to disable this.

@pat-s
Copy link
Contributor

pat-s commented Feb 23, 2023

I actually also like that this is possible in OTF right now. Making it configurable to allow CLI applies would be awesome!

@leg100 leg100 mentioned this issue Aug 6, 2023
Merged
@leg100 leg100 changed the title Prohibit CLI apply on connected workspace Permit CLI apply on connected workspace Aug 6, 2023
@leg100
Copy link
Owner Author

leg100 commented Aug 6, 2023 •
edited
Loading

@fsaintjacques @pat-s

A recent change to OTF inadvertently implemented the same behaviour as TFC, prohibiting CLI applies against connected workspaces, and if you tried to run terraform apply you'd get the exact same error message shown above.

I've done as you requested @fsaintjacques and implemented a toggle in #564 to allow you to override this default behaviour.

leg100 added a commit that referenced this issue Aug 6, 2023
@leg100
feat: allow terraform apply on connected workspace (#564)
6f90a9c 
Fixes #231
@github-actions github-actions bot mentioned this issue Aug 6, 2023
Merged
@fsaintjacques
Copy link
Contributor

Thank you!

leg100 pushed a commit that referenced this issue Aug 13, 2023
@github-actions
chore(master): release 0.1.8 (#561)
9c6d0f6 
🤖 I have created a release *beep* *boop*
---


## [0.1.8](v0.1.7...v0.1.8)
(2023-08-13)


### Features

* allow terraform apply on connected workspace
([#564](#564))
([6f90a9c](6f90a9c)),
closes [#231](#231)
* **ui:** add icon in run widget to show source of run
([#563](#563))
([2e7a0bd](2e7a0bd))


### Bug Fixes

* cleanup after extracting repo tarball
([bf4758b](bf4758b))
* don't scrub included state output sensitive values
([478e314](478e314))
* linux/arm64 support ([#562](#562))
([01a2112](01a2112)),
closes [#311](#311)
* otfd compose healthcheck: curl not installed
([9f52021](9f52021))
* retry run should use existing run properties
([49303ec](49303ec))
* **tests:** hard link fails when /tmp is separate partition
([cfc7aaa](cfc7aaa))
* **ui:** workspace description missing after update
([a579b40](a579b40))
* use png instead of svg for font-based icons
([eae0588](eae0588))


### Miscellaneous

* bump squid version
([7ce3238](7ce3238))
* go 1.21 ([#566](#566))
([06c13b2](06c13b2))
* remove unused cloud team and org sync code
([4e1817d](4e1817d))
* removed unused ca.pem
([799ed25](799ed25))
* skip api tests if env vars not present
([5b88474](5b88474))
* **ui:** make tags less bulbous
([df1645d](df1645d))
* **ui:** pad out buttons on consent page
([1c290e9](1c290e9))
* update docs
([364d183](364d183))
* validate resource names
([c7596fe](c7596fe))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this issue Aug 13, 2023
Merged
leg100 pushed a commit that referenced this issue Aug 13, 2023
@github-actions
chore(master): release 0.1.8 (#568)
4a1ef8d 
🤖 I have created a release *beep* *boop*
---


## [0.1.8](v0.1.7...v0.1.8)
(2023-08-13)


### Features

* allow terraform apply on connected workspace
([#564](#564))
([6f90a9c](6f90a9c)),
closes [#231](#231)
* **ui:** add icon in run widget to show source of run
([#563](#563))
([2e7a0bd](2e7a0bd))


### Bug Fixes

* cleanup after extracting repo tarball
([bf4758b](bf4758b))
* don't scrub included state output sensitive values
([478e314](478e314))
* linux/arm64 support ([#562](#562))
([01a2112](01a2112)),
closes [#311](#311)
* otfd compose healthcheck: curl not installed
([9f52021](9f52021))
* qemu needed for building multi-arch images
([1aa8cf8](1aa8cf8))
* retry run should use existing run properties
([49303ec](49303ec))
* **tests:** hard link fails when /tmp is separate partition
([cfc7aaa](cfc7aaa))
* **ui:** workspace description missing after update
([a579b40](a579b40))
* use png instead of svg for font-based icons
([eae0588](eae0588))


### Miscellaneous

* bump squid version
([7ce3238](7ce3238))
* go 1.21 ([#566](#566))
([06c13b2](06c13b2))
* **master:** release 0.1.8
([#561](#561))
([9c6d0f6](9c6d0f6))
* remove unused cloud team and org sync code
([4e1817d](4e1817d))
* removed unused ca.pem
([799ed25](799ed25))
* skip api tests if env vars not present
([5b88474](5b88474))
* **ui:** make tags less bulbous
([df1645d](df1645d))
* **ui:** pad out buttons on consent page
([1c290e9](1c290e9))
* update docs
([364d183](364d183))
* validate resource names
([c7596fe](c7596fe))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@leg100 @fsaintjacques @pat-s