fix: cleanup after extracting repo tarball

leg100 · Aug 7, 2023 · bf4758b · bf4758b
1 parent 478e314
commit bf4758b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/internal/github/client.go b/internal/github/client.go
@@ -207,12 +207,12 @@ func (g *Client) GetRepoTarball(ctx context.Context, opts cloud.GetRepoTarballOp
 	// <owner>-<repo>-<commit>. We need a tarball without this parent directory,
 	// so we untar it to a temp dir, then tar it up the contents of the parent
 	// directory.
-	//
-	// TODO: remove temp dir after finishing
 	untarpath, err := os.MkdirTemp("", fmt.Sprintf("github-%s-%s-*", owner, name))
 	if err != nil {
 		return nil, "", err
 	}
+	defer os.RemoveAll(untarpath)
+
 	if err := internal.Unpack(resp.Body, untarpath); err != nil {
 		return nil, "", err
 	}

diff --git a/internal/gitlab/client.go b/internal/gitlab/client.go
@@ -162,6 +162,8 @@ func (g *Client) GetRepoTarball(ctx context.Context, opts cloud.GetRepoTarballOp
 	if err != nil {
 		return nil, "", err
 	}
+	defer os.RemoveAll(untarpath)
+
 	if err := internal.Unpack(bytes.NewReader(tarball), untarpath); err != nil {
 		return nil, "", err
 	}