fix: finish events refactor #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leg100
pushed a commit
that referenced
this pull request
Jul 8, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.51](v0.0.50...v0.0.51) (2023-07-08) ### Bug Fixes * apply on output changes ([#501](#501)) ([46cd3ef](46cd3ef)) * delete unreferenced tags ([#507](#507)) ([d85ac43](d85ac43)), closes [#502](#502) * finish events refactor ([#509](#509)) ([096933a](096933a)) * flaky browser tests ([#484](#484)) ([1ce0bd0](1ce0bd0)) * prevent empty owners team ([#499](#499)) ([a77c9e9](a77c9e9)) ### Miscellaneous * Bump default terraform version to v1.5.2 ([#503](#503)) ([67bc3f0](67bc3f0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
leg100
pushed a commit
that referenced
this pull request
Jul 8, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.51](v0.0.50...v0.0.51) (2023-07-08) ### Bug Fixes * apply on output changes ([#501](#501)) ([46cd3ef](46cd3ef)) * delete unreferenced tags ([#507](#507)) ([d85ac43](d85ac43)), closes [#502](#502) * finish events refactor ([#509](#509)) ([096933a](096933a)) * flaky browser tests ([#484](#484)) ([1ce0bd0](1ce0bd0)) * prevent empty owners team ([#499](#499)) ([a77c9e9](a77c9e9)) ### Miscellaneous * Bump default terraform version to v1.5.2 ([#503](#503)) ([67bc3f0](67bc3f0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
leg100
pushed a commit
that referenced
this pull request
Jul 8, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.51](v0.0.50...v0.0.51) (2023-07-08) ### Bug Fixes * apply on output changes ([#501](#501)) ([46cd3ef](46cd3ef)) * delete unreferenced tags ([#507](#507)) ([d85ac43](d85ac43)), closes [#502](#502) * finish events refactor ([#509](#509)) ([096933a](096933a)) * flaky browser tests ([#484](#484)) ([1ce0bd0](1ce0bd0)) * prevent empty owners team ([#499](#499)) ([a77c9e9](a77c9e9)) ### Miscellaneous * Bump default terraform version to v1.5.2 ([#503](#503)) ([67bc3f0](67bc3f0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events refactor from several weeks ago, #458, introduced postgres triggers as a means of publishing events. But it was never 100% completed, leaving behind many
Publish()calls that do nothing.Furthermore, the refactor introduced a regression: the agent event subscriber was not also refactored and therefore it no longer received cancelation events. When a user canceled a run, the run status would be set to canceled but the terraform process would not receive an interrupt signal. This PR fixes this, and introduces an integration test to prevent re-occurance of the regression.