feat!: adding team member creates user if they don't exist #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leg100
pushed a commit
that referenced
this pull request
Jul 24, 2023
🤖 I have created a release *beep* *boop* --- ## [0.1.0](v0.0.53...v0.1.0) (2023-07-24) ### ⚠ BREAKING CHANGES * adding team member creates user if they don't exist ([#525](#525)) ### Features * adding team member creates user if they don't exist ([#525](#525)) ([fbeb789](fbeb789)) * organization tokens ([#528](#528)) ([7ddd416](7ddd416)) * **ui:** tag search/dropdown menu ([#523](#523)) ([09b8310](09b8310)) ### Bug Fixes * embed magnifying glass icon ([8a45d51](8a45d51)) * run tailwind css on template changes ([e749013](e749013)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of the add team member functionality, both via the UI and the API: when adding a user to a team, if the user does not exist the user is created.
This is a deviation from TFC's behaviour. But then OTF already differs quite a bit from TFC when it comes to users: in OTF, users are not "invited" and are instead created the first time they login. There is no email functionality because that would add a further dependency (a mail relay).