fix: handle run-events request from terraform cloud backend #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leg100
pushed a commit
that referenced
this pull request
Jul 26, 2023
🤖 I have created a release *beep* *boop* --- ## [0.1.2](v0.1.1...v0.1.2) (2023-07-26) ### Bug Fixes * agent race error ([#537](#537)) ([6b9e6b1](6b9e6b1)) * handle run-events request from terraform cloud backend ([#534](#534)) ([b1998bd](b1998bd)) * terraform apply partial state updates ([#539](#539)) ([d25e7e4](d25e7e4)), closes [#527](#527) ### Miscellaneous * removed unused config file ([84fe3b1](84fe3b1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terraform plan|applyas of v1.5 sends a request to/api/v2/runs/<run_id>/run-eventsif using thecloudbackend. OTF did not handle this request and hence terraform would error withresource not found.This PR stubs this endpoint, returning an empty response, which works around the issue.
(Run events would usually be warnings about various policy issues OTF doesn't implement anyway).