fix: resubscribe subsystems when their subscription is terminated #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leg100 Thanks! Waiting for the new release so I can test. |
leg100
pushed a commit
that referenced
this pull request
Sep 11, 2023
🤖 I have created a release *beep* *boop* --- ## [0.1.11](v0.1.10...v0.1.11) (2023-09-11) ### Features * update vcs provider token ([#594](#594)) ([29a0be6](29a0be6)), closes [#576](#576) ### Bug Fixes * dont scrub sensitive variable values for agent ([#591](#591)) ([a333ee6](a333ee6)), closes [#590](#590) * **integration:** prevent -32000 error ([39318f1](39318f1)) * **integration:** wait for alpinejs to load ([346024e](346024e)) * resubscribe subsystems when their subscription is terminated ([#593](#593)) ([3195e17](3195e17)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
leg100
added a commit
that referenced
this pull request
Sep 13, 2023
Fixes #577 (again). The original fix, #593, left out the agent spooler system, which is responsible for relaying run events to the agent. So when its subscription was terminated, it didn't restart itself. This PR changes that: the spooler will now restart itself whenever its subscription is terminated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #577
The events broker can legitimately terminate the subscription of a subscriber, e.g. when the subscriber's event queue is full up. Various subsystems such as the scheduler would, in such a scenario, simply shutdown. Which in the case of #577 would mean no more runs could be started.
This PR changes the behaviour of the subsystems: when their subscription is terminated, they instead return an error, which triggers the subsystem to be restarted (using a backoff algorithm) rather than stop completely.