fix: fixed defect with multiline tfvars not being escaped #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbert229
commented
Oct 27, 2023
| @@ -281,6 +281,15 @@ func WriteTerraformVars(dir string, vars []*Variable) error { | |||
| b.WriteString(" = ") | |||
| if v.HCL { | |||
| b.WriteString(v.Value) | |||
There was a problem hiding this comment.
Here we are using EOT as the base delimiter for the heredoc, and optionally adding extra Ts to it if the delimiter is already contained by the value.
|
Thanks! Good point re double quotes, backspaces, etc. We'll tackle those another day. |
leg100
added a commit
that referenced
this pull request
Oct 27, 2023
🤖 I have created a release *beep* *boop* --- ## [0.1.15](v0.1.14...v0.1.15) (2023-10-27) ### Features * Implement TFE API for Team Tokens (#624) 1e4b173 ### Bug Fixes * fix local execution mode (#627) aefb365 * agent error reporting ([#628](#628)) ([76e7dda](76e7dda)) * fixed defect with multiline tfvars not being escaped ([#631](#631)) ([f35dffa](f35dffa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Garman <75728+leg100@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #630 by using heredocs in variables when that variable includes a newline.
This PR isn't intended to fix all escaping with the WriteTerraformVars function, and there are other ways that this can be broken (for example using backspaces and double quotes within the value of the variable)