Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_domains and include_entities #49

Closed
ooii opened this issue Jan 29, 2019 · 6 comments · Fixed by #147
Closed

Add include_domains and include_entities #49

ooii opened this issue Jan 29, 2019 · 6 comments · Fixed by #147
Labels
enhancement New feature or request
Milestone

Comments

@ooii
Copy link

ooii commented Jan 29, 2019

Is your feature request related to a problem? Please describe.
Currently, the configuration file allows for excluding domains and entities. If one needs to send only few data to ES, then she/he needs to add all other domains to the exclude_domains array.

Describe the solution you'd like
Add include_domains and include_entities with a precedence that included entities override excluded domains (and that excluded entities override include domains?).

@legrego legrego added the enhancement New feature or request label Jan 29, 2019
@legrego
Copy link
Owner

legrego commented Jan 30, 2019

Thanks for the suggestion! I'll see what it takes to add this, unless you (or someone else) wants to give it a shot.

@legrego legrego added this to the Version 1.0 milestone Jan 30, 2019
@ooii
Copy link
Author

ooii commented Jan 30, 2019

I'll give a look to the code. I don't know if my skills allow me to contribute at that level. But it'd be with pleasure.

Edit: I sent a PR but without testing (please, do not blame me for that, tight schedule).

@joostvanmourik
Copy link

Can you also send me the the version with include, i only wan't to use this for my Toon data (5 entities)

@jakommo
Copy link
Contributor

jakommo commented Mar 4, 2019

Hey @joostvanmourik , this functionality hasn't been added yet, you can follow the PR #50 for the conversation on this topic.
If you are used to python, you could also try merging in the changes manually on your local machine from this diff https://github.com/legrego/homeassistant-elasticsearch/pull/50/files, but judging from the conversation in the PR it's not done yet and hasn't been tested, so it might be worth to wait for it to be merged.

@joostvanmourik
Copy link

Hey @joostvanmourik , this functionality hasn't been added yet, you can follow the PR #50 for the conversation on this topic.
If you are used to python, you could also try merging in the changes manually on your local machine from this diff https://github.com/legrego/homeassistant-elasticsearch/pull/50/files, but judging from the conversation in the PR it's not done yet and hasn't been tested, so it might be worth to wait for it to be merged.

Thanx i'am not very good with Pyton so for now i just try to exclude as much as possible :-)

@legrego
Copy link
Owner

legrego commented Aug 11, 2021

I have a PR up to add support for this: #147
I still need to test this before merging, but the changes were fairly minimal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants