Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Launch at Login feature #76

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Add Launch at Login feature #76

merged 3 commits into from
Sep 17, 2020

Conversation

jogendra
Copy link
Contributor

@jogendra jogendra commented Sep 13, 2020 •
edited
Loading

Status

DONE

Description

Added Launch at Login feature to app preferences so that users can select if they automatically want to start the app when they start their system.
Feature issue: #27

This is how it looks:
Screenshot 2020-09-13 at 17 59 41

Steps to Test or Reproduce

Go to Preference > General > Launch at Login

@jogendra
Add AutoLauncher to project
cab674f
@jogendra
Add: Launch at Login to Preferences
0779721 
Remove UI components from AutoLauncher

Recreated AutoLauncher

Add comments for deleting path

Remove UI components from AutoLauncher

Remove Storyboard from AutoLauncher

Delete Breakpoints_v2.xcbkptlist

Delete xcschememanagement.plist

Small fixes

Add back apple signing
@jogendra jogendra marked this pull request as ready for review September 13, 2020 16:59
@jogendra
Copy link
Contributor Author

Hey @leits 👋
Please review ✨

leits
leits reviewed Sep 14, 2020
View reviewed changes
AutoLauncher/AppDelegate.swift Outdated Show resolved Hide resolved
MeetingBar.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
MeetingBar/Constants.swift Outdated Show resolved Hide resolved
Itaybre
Itaybre reviewed Sep 14, 2020
View reviewed changes
AutoLauncher/AutoLauncher.entitlements Outdated Show resolved Hide resolved
MeetingBar.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@jogendra jogendra requested a review from leits September 14, 2020 17:28
@jogendra
Copy link
Contributor Author

jogendra commented Sep 14, 2020 •
edited
Loading

@leits @Itaybre thanks for reviewing. I tested the feature by restarting my machine and it is working as expected.
But it is showing MeetingBar in the text on the top menu instead of App Icon, not sure about the reason behind it.

@Itaybre
Copy link
Contributor

Itaybre commented Sep 15, 2020

@jogendra I don't quite understand what you mean by that, can you post a picture?

@jogendra
Copy link
Contributor Author

Screenshot from the stable release:
Screenshot 2020-09-15 at 08 39 26

(App Icon is showing in the Menu)

Screenshot from my Build:
Screenshot 2020-09-15 at 08 39 09

(App name (MeetingBar) is shown in the menu instead of the App icon.

@Itaybre

@Itaybre
Copy link
Contributor

Itaybre commented Sep 15, 2020

Seems like no calendars were loaded (it is the default case)

@Itaybre
Copy link
Contributor

Itaybre commented Sep 15, 2020

Does this build work normally? Defaults are recorder per app, and maybe your local app has a different identifier, thus nothing is loaded

@jogendra
Copy link
Contributor Author

jogendra commented Sep 15, 2020 •
edited
Loading

Ahha okay. I thought it was something that went wrong from my side. Thanks for clarifying:) @Itaybre

You can review requested changes.

@leits leits self-assigned this Sep 16, 2020
@leits leits added the feature New feature or request label Sep 16, 2020
@leits leits added this to the 1.6 milestone Sep 16, 2020
@leits leits linked an issue Sep 16, 2020 that may be closed by this pull request
As a user I would like meeting bar to automatically open on login #27
Closed
@leits
Copy link
Owner

leits commented Sep 16, 2020

LGTM
@Itaybre, approve if you have no more questions.

Itaybre
Itaybre approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@Itaybre Itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me @leits

@leits leits merged commit cbab502 into leits:master Sep 17, 2020
@leits
Copy link
Owner

leits commented Sep 17, 2020

Thanks, @jogendra! Merged 🚀

@jogendra
Copy link
Contributor Author

Hey @leits @Itaybre

I wrote a blog post about implementing Launch at Login feature. Let me know what do you think about it :)

Link: https://jogendra.dev/implementing-launch-at-login-feature-in-macos-apps

@Itaybre
Copy link
Contributor

Itaybre commented Sep 20, 2020

@jogendra great post, didn't see any mention to the identifier requirements which is a must if you want to release the app that on the AppStore

@jogendra
Copy link
Contributor Author

@Itaybre Thanks 👍

I think I mentioned bundle identifiers in code snippets and also they are visible in screenshots. Not sure what I missed

@leits
Copy link
Owner

leits commented Sep 21, 2020

@jogendra. Great article! I like the level of detail. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Itaybre Itaybre Itaybre approved these changes

@leits leits leits approved these changes

Assignees

@leits leits

Labels
feature New feature or request
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

As a user I would like meeting bar to automatically open on login
3 participants
@jogendra @Itaybre @leits