Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <summary> to default whitelist #216

Merged
merged 1 commit into from
May 6, 2021

Conversation

spacegaier
Copy link
Contributor

Since <details> is in there, it makes sense for <summary> as well since that is used inside <details> to define the text label/title for the collapsible element.

See example: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details

Since `<details>` is in there, it makes sense for `<summary>` as well since that is used inside `<details>` to define the text label/title for the collapsible element.
@leizongmin leizongmin merged commit 71ce4bf into leizongmin:master May 6, 2021
@spacegaier
Copy link
Contributor Author

@leizongmin Thank you for merging it in 👍 . Do you plan to release a new minor version with the current batch of merges so we can pull in the new version into other projects?

@spacegaier spacegaier deleted the patch-1 branch May 6, 2021 03:29
@leizongmin
Copy link
Owner

Yes, I will publish a new version later.

@spacegaier
Copy link
Contributor Author

@leizongmin I noticed that this chore commit removed summary again: 1f0f0b6

leizongmin added a commit that referenced this pull request May 6, 2021
Add `<summary>` to default whitelist
@leizongmin
Copy link
Owner

I have published a new version xss@1.0.9 including the following changes:

@spacegaier
Copy link
Contributor Author

spacegaier commented May 6, 2021

@leizongmin Thank you for the new version! Will directly get on pulling that into Home-Assistant 👍.

Could you also mark a release here on GitHub? Then people can easily compare the changes.

EDIT: NVM, you just created it 30 seconds ago. Great!

@leizongmin
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants