Fixes for #203: visible children of hidden parents #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dairiki
changed the title
dairiki
force-pushed
the
bug.203-non-hidden-children
branch
from
8f17c81
to
142865e
Compare
Previously, checkboxes were only being marked _indeterminate_
if the default ("placeholder") value was true. They should be
indeterminate whenever this is no explicitly set value.
Also lower the opacity for indeterminate checkboxes, to make them more
visually distinctive.
- Test devserver when serving hidden pages and their children - Test URL resolution below hidden pages - Add tests that children of hidden pages get built - Test that artifacts of hidden pages get pruned
Even though hidden records produce no artifacts, they may have non-hidden children. See lektor#203
There may be non-hidden children below hidden pages.
dairiki
force-pushed
the
bug.203-non-hidden-children
branch
from
142865e
to
d1057c0
Compare
dairiki
force-pushed
the
bug.203-non-hidden-children
branch
from
075449e
to
fc3e87a
Compare
One can now type the <delete> or <backspace> key to "unset" the checkbox. This is useful for the `_hidden` field where, _unset_ has different semantics than `false`.
dairiki
force-pushed
the
bug.203-non-hidden-children
branch
from
fc3e87a
to
f0d87b7
Compare
Previous method of checking the `checked` HTML attribute doesn't work since React Controlled Components never update the `checked` HTML attribute after the initial mount.
|
This is now fixed in the If there's a desire for this to be backported to the 3.3 branch, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows one to have visible children under a hidden parent page. No artifact (e.g.
index.html) will be built for the hidden parent, but artifact(s) will now be built for any explicitly non-hidden children.Contrary to what the documentation says, up until now, Lektor made no attempt to build children of a hidden parent.
Other changes here:
contents.lrfile does not explicitly set a value for the field, regardless of what the default value is.trueorfalse. This is important for the_hiddenfield, since when the_hiddenfield is unset it means something different (e.g. "inherit from parent") than when_hidden = false(or_hidden = true).Issue(s) Resolved
Fixes #203
Related Issues / Links
Clarified documentation on the
_missingfield in lektor/lektor-website@7a6ccd0Description of Changes
_hiddenunset ≠_hidden = no)