Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #203: visible children of hidden parents #1048

Merged
merged 9 commits into from
Aug 2, 2022

Commits on Jul 26, 2022

  1. admin: fix initialization of indeterminate checkboxes

    Previously, checkboxes were only being marked _indeterminate_
    if the default ("placeholder") value was true.  They should be
    indeterminate whenever this is no explicitly set value.
    
    Also lower the opacity for indeterminate checkboxes, to make them more
    visually distinctive.
    dairiki committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    1614cc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Add tests for bugs to be fixed in this PR

    - Test devserver when serving hidden pages and their children
    - Test URL resolution below hidden pages
    - Add tests that children of hidden pages get built
    - Test that artifacts of hidden pages get pruned
    dairiki committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    034a439 View commit details
    Browse the repository at this point in the history
  2. builder: build hidden records

    Even though hidden records produce no artifacts, they may have
    non-hidden children.
    
    See lektor#203
    dairiki committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    fde7d0a View commit details
    Browse the repository at this point in the history
  3. db: traverse hidden pages when resolving URLs

    There may be non-hidden children below hidden pages.
    dairiki committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    17ab6e4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8e2b605 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d1057c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2022

  1. Enhance checkbox for tri-state

    One can now type the <delete> or <backspace> key to "unset" the
    checkbox.
    
    This is useful for the `_hidden` field where, _unset_ has different
    semantics than `false`.
    dairiki committed Jul 30, 2022
    Configuration menu
    Copy the full SHA
    f0d87b7 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2022

  1. Configuration menu
    Copy the full SHA
    515ee4c View commit details
    Browse the repository at this point in the history
  2. Styling of indeterminate checkboxes depends on default value

    Previous method of checking the `checked` HTML attribute doesn't work
    since React Controlled Components never update the `checked` HTML
    attribute after the initial mount.
    dairiki committed Jul 31, 2022
    Configuration menu
    Copy the full SHA
    66cb384 View commit details
    Browse the repository at this point in the history