refactor: Disuse watchdog in favor of watchfiles.
#1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might this enable closing out #550 easily? |
Yes. Actually, I think it (inadvertently) fixes that already. I chose to have our WatchFilter inherit from watchfiles' |
dairiki
force-pushed
the
refactor.watchfiles
branch
6 times, most recently
from
44687b8
to
d13a850
Compare
Watchfiles has a much cleaner API. Also, it's a flail, but I hope it might help with the hanging CI tests on macOS (which seem to be related to watchdog.)
On macOS, watchfiles.watch sometimes seems to return events for filesystem changes that happened slightly before the watcher was started. To keep that from screwing up the tests, wait a bit before starting each test.
The project file does not necessarily have to be the project source tree.
dairiki
force-pushed
the
refactor.watchfiles
branch
from
d13a850
to
e58a2c3
Compare
2 tasks
dairiki
added a commit
to dairiki/lektor
that referenced
this pull request
Sep 11, 2023
* refactor: use watchfiles instead of watchdog Watchfiles has a much cleaner API. Also, it's a flail, but I hope it might help with the hanging CI tests on macOS (which seem to be related to watchdog.) * fix(test): (macOS) wait a bit for pending watch event to settle * refactor: code cleanup * fix: watch the project file for changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watchfiles has a much cleaner API.
It has a (Rust-based) extension module, but wheels are distributed for a wide variety of targets.
Also, it's a flail, but I hope it might help with the hanging CI tests (see #1132) on macOS (which seem to be related to watchdog.)
Issue(s) Resolved
It simplifies our code quite a bit.
It might fix the CI test hangage on macOS.
Fixes #550
Fixes #1116
Related Issues / Links
#1132
#861
Description of Changes