Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Disuse watchdog in favor of watchfiles. #1136

Merged
merged 4 commits into from
May 6, 2023
Merged

refactor: Disuse watchdog in favor of watchfiles. #1136

merged 4 commits into from
May 6, 2023

Commits on May 6, 2023

  1. refactor: use watchfiles instead of watchdog 

    Watchfiles has a much cleaner API.

Also, it's a flail, but I hope it might help with the hanging CI tests
on macOS (which seem to be related to watchdog.)
    @dairiki
    dairiki committed May 6, 2023
    Configuration menu
    Copy the full SHA
    dd228f6 View commit details
    Browse the repository at this point in the history

  2. fix(test): (macOS) wait a bit for pending watch event to settle 

    On macOS, watchfiles.watch sometimes seems to return events for
filesystem changes that happened slightly before the watcher was
started.  To keep that from screwing up the tests, wait a bit
before starting each test.
    @dairiki
    dairiki committed May 6, 2023
    Configuration menu
    Copy the full SHA
    82e8737 View commit details
    Browse the repository at this point in the history

  3. refactor: code cleanup

    @dairiki
    dairiki committed May 6, 2023
    Configuration menu
    Copy the full SHA
    ec4c71d View commit details
    Browse the repository at this point in the history

  4. fix: watch the project file for changes 

    The project file does not necessarily have to be the project source tree.
    @dairiki
    dairiki committed May 6, 2023
    Configuration menu
    Copy the full SHA
    e58a2c3 View commit details
    Browse the repository at this point in the history