-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lektor 613 - Passing extra_flags to all plugin events #651
Conversation
…ified a couple other tests to make match. Made the scratch project include *real* markdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me at a first glance, but I'm not super duper familiar with the codebase.
Looks like I messed up the working directory pathing of the tests a bit. I'm fixing that. Thanks for the look! |
…es cwd the plugins tests end with, fixing broken subsequent tests.
… dev shell command.
I think I'm done modifying this, tweaking the tests. |
Looks pretty good in general :-) |
Fixes #613.
This passes extra_flags to every plugin event, and allows extra_flags in a few more commands like
clean
anddev shell
. This includes tests for most of the added functionality.The tests could be improved, but the bigger deficiencies are not easy to overcome:
lektor server
;server_spawn
andserver_stop
. Maybe there's an easy way I haven't thought of?IMO, none of those are bad enough to block this. I'll happily accept recommended changes though if someone thinks of something I haven't :)
Ping @Andrew-Shay, for lektor/lektor-website#256.