Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicting Namespaces #2

Closed
aconz2 opened this issue Mar 17, 2015 · 4 comments
Closed

Conflicting Namespaces #2

aconz2 opened this issue Mar 17, 2015 · 4 comments

Comments

@aconz2
Copy link
Contributor

aconz2 commented Mar 17, 2015

SIMDCompressionAndIntersection shares many classes and header file names with FastPFor. When using them together, there are issues since this library doesn't enclose anything in a namespace.
I'm proposing renaming all #ifndef NAME_H_ to #ifndef SIMDCompressionAndIntersection_NAME_H_ and enclosing all relevant pieces in a namespace, maybe called SIMDCompressionLib?
If these sound like reasonable names and changes, I will go ahead and do so.
@lemire
Copy link
Owner

lemire commented Mar 17, 2015

Yes, this does sound reasonable. A PR would be appreciated.

@aconz2
Copy link
Contributor Author

aconz2 commented Mar 17, 2015

Submitted: #3

@lemire
Copy link
Owner

lemire commented Mar 18, 2015

@aconz2

Your PR is excellent. I have added your name to the README and CHANGELOG.

I am closing this issue, reopen if you disagree.

@lemire lemire closed this as completed Mar 18, 2015
@aconz2
Copy link
Contributor Author

aconz2 commented Mar 18, 2015

Cheers. Thanks for making this code available in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lemire @aconz2