Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Dockerfile #2

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Dockerfile #2

merged 3 commits into from
Jun 20, 2023

Conversation

thebigG
Copy link
Contributor

@thebigG thebigG commented Jun 19, 2023

I managed to build it inside docker. I had to, unfortunately, build libadwaita from source. But it builds!

This resolves issues in #1.

Hope the changes here make sense. Let me know if the Dockerfile/README can be improved in any way!

Thanks so much for your help @Bnyro !

@Bnyro
Copy link
Member

Bnyro commented Jun 19, 2023

That is so awesome, thank you so much!
Wouldn't it be possible to use a docker image of a distro that has the latest version of libadwaita in the repos, like for example Void Linux or Arch Linux? That could improve the build times a lot since we wouldn't need to compile it ourselves then.

@Bnyro
Copy link
Member

Bnyro commented Jun 19, 2023

And I'm not actually sure why we require libadwaita as build dependency although we don't use Adwaita currently, maybe there's a way to exclude it from the projects rust dependencies

@thebigG
Copy link
Contributor Author

thebigG commented Jun 19, 2023

Wouldn't it be possible to use a docker image of a distro that has the latest version of libadwaita in the repos, like for example Void Linux or Arch Linux? That could improve the build times a lot since we wouldn't need to compile it ourselves then.

Indeed this should be pretty feasible to do this. All I would need is the specific linux distro that has the right version in the repos. Which arch version did you use to build?

@Bnyro
Copy link
Member

Bnyro commented Jun 20, 2023

I used the latest version of Void Linux, (it's a rolling release distro), so just doing xpbs-install -Syu to update the system should be fine. Packages can be installed with xbps-install gtk4-devel for example.

@Bnyro Bnyro merged commit 98b6219 into lemmygtk:main Jun 20, 2023
@Bnyro
Copy link
Member

Bnyro commented Jun 20, 2023

Thank you! I hope everything still builds fine for you, at least it did on my machine :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants