Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16px icon does not get saved #5

Closed
gingerbeardman opened this issue Oct 24, 2017 · 11 comments
Closed

16px icon does not get saved #5

gingerbeardman opened this issue Oct 24, 2017 · 11 comments

Comments

@gingerbeardman
Copy link

gingerbeardman commented Oct 24, 2017

after saving:
screen shot 2017-10-24 at 17 02 41

after loading:
screen shot 2017-10-24 at 17 02 50

as you can see the 16px icon is missing after the icon is reloaded

@gingerbeardman
Copy link
Author

I've verified in Preview that the 16x16 image does not exist in the saved icon.

@lemonmojo
Copy link
Owner

Unfortunately that appears to be a bug in iconutil that ships with macOS High Sierra. I've filed a bug report with Apple and copied it to Open Radar.

@gingerbeardman
Copy link
Author

Excellent, thanks

@schroef
Copy link

schroef commented Apr 26, 2019

I still see this issue, yet not on all files. Im still on 10.11.6 and just updated to 1.2 still happens now and then???

@schroef
Copy link

schroef commented Apr 26, 2019

PS why does this app needs to be fullscreen. It makes dropping in icons to much of a hustle

@lemonmojo
Copy link
Owner

@schroef Interesting. Haven't touched 10.11 in a while. Anyway, since the app just uses iconutil under the hood, the issue is likely related to bugs in iconutil rather than the app itself. Since it's open source, just try debugging and check where it fails. The app doesn't need to be fullscreen. Not sure why you're stating that?!

@schroef
Copy link

schroef commented May 1, 2019

I'm not sure how you should add icons to this. I do it by dragging in PNG files from a finder window. BUt because the app window is huge and doesnt show all icon sizes. Its a pain in the ass and tedious to add them all.

Screen Shot 2019-05-01 at 19 25 30

This is my best go at it.
Screen Shot 2019-05-01 at 19 27 19

What would be nice if you simply select all sizes and the app understand which image should where. That would be hard if it looks at the suffix of an image i guess.
Screen Shot 2019-05-01 at 19 27 19

@schroef
Copy link

schroef commented May 1, 2019

PS perhaps the issue is related that when using iconutils in the terminal you also need to add pixel doubling icons.

That set looks like this
Screen Shot 2019-05-01 at 19 30 00

But after testing it again. Also iconutils from osx terminal using that method shows no icon in list mode. It does show once i add the icon inside the app. So perhaps its a cache issue?
Screen Shot 2019-05-01 at 19 33 40

I used the codes from this thread; https://stackoverflow.com/questions/12306223/how-to-manually-create-icns-files-using-iconutil
Which got its data from this link; https://developer.apple.com/library/archive/documentation/GraphicsAnimation/Conceptual/HighResolutionOSX/Optimizing/Optimizing.html

@lemonmojo
Copy link
Owner

lemonmojo commented May 2, 2019

@schroef Well, the app was designed on a big screen and I haven't had the need for it to support zooming. Please feel free to submit a PR which improves this.

Also, of course the app generates the @2x variants of the icons you drag into it. That's the whole point of the app. Since the original Apple version does not support retina icons. If you take a look at the source code, the app actually uses iconutil to do the conversion to .icns.

@schroef
Copy link

schroef commented May 3, 2019

okay thanks! Both have the same issue indeed. At first they wont show the 16px icon. But somehow later it does???

@gingerbeardman
Copy link
Author

16px icon seems to be saved in Mojave, at least for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants