Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SET_TEXT_DROPSHADOW in ScaledText #169

Closed
justalemon opened this issue Mar 20, 2024 · 2 comments
Closed

Implement SET_TEXT_DROPSHADOW in ScaledText #169

justalemon opened this issue Mar 20, 2024 · 2 comments
Labels
priority: p3 low A cosmetic bug or a new feature request status: completed The feature has been completed of the bug has been patched type: feature request Request to implement a specific feature

Comments

@justalemon
Copy link
Member

SET_TEXT_DROPSHADOW allows you to make a more customizable drop shadow than SET_TEXT_DROP_SHADOW.

@justalemon justalemon added priority: p3 low A cosmetic bug or a new feature request type: feature request Request to implement a specific feature status: acknowledged We are aware of the bug or feature request labels Mar 20, 2024
@justalemon justalemon added this to the 2.1 milestone Mar 20, 2024
@justalemon justalemon added status: completed The feature has been completed of the bug has been patched and removed status: acknowledged We are aware of the bug or feature request labels May 24, 2024
@kagikn
Copy link
Contributor

kagikn commented May 24, 2024

I noticed this issue now, but you assumed wrong. SET_TEXT_DROPSHADOW just does the same thing as SET_TEXT_DROP_SHADOW unless a non-positive value is passed as the 1st argument. The 2nd to 5th argument is marked as UNUSED_PARAM in commands_hud.cpp and the native implementation doesn't even use none of them. If the 1st arg is not positive, the drop shadows is removed for the next text draw.

I wish I noticed the wrong assumption before releasing any stable releases tbh...

@justalemon
Copy link
Member Author

Oh, I didn't checked commands_hud.cpp before committing, I used Dot's NativeDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 low A cosmetic bug or a new feature request status: completed The feature has been completed of the bug has been patched type: feature request Request to implement a specific feature
Projects
None yet
Development

No branches or pull requests

2 participants