Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preheater actions failing #7

Closed
lissmeister opened this issue Feb 14, 2021 · 2 comments
Closed

Preheater actions failing #7

lissmeister opened this issue Feb 14, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@lissmeister
Copy link

In version 1.0.30 this was working just fine, but the following commit (98b5118) breaks this functionality. {BRAND}/{COUNTRY} does not get subsituted for skoda/CZ in the request url. When hardcoding it in line 851 of connection.py the preheater functions as expected again.

Other requests, such as fetching status seem to work just fine according to the log though.

Working:

DEBUG (MainThread) [skodaconnect.connection] HTTP POST "https://msg.volkswagen.de/fs-car/bs/rs/v1/skoda/CZ/vehicles/vin/action"
DEBUG (MainThread) [skodaconnect.connection] Request for "https://msg.volkswagen.de/fs-car/bs/rs/v1/skoda/CZ/vehicles/vin/action" returned with status code [202], response: {'performActionResponse': {'requestId': '19643149', 'vin': 'vin'}, 'rate_limit_remaining': '14'}

Not working:

DEBUG (MainThread) [skodaconnect.connection] HTTP POST "https://msg.volkswagen.de/fs-car/bs/rs/v1/{BRAND}/{COUNTRY}/vehicles/vin/action"
ERROR (MainThread) [skodaconnect.connection] Bad request
WARNING (MainThread) [skodaconnect.vehicle] Failed to set parking heater mode to heating - Invalid or no response
  File "/config/custom_components/skodaconnect/switch.py", line 32, in async_turn_on
  File "/usr/local/lib/python3.8/site-packages/skodaconnect/dashboard.py", line 526, in turn_on
  File "/usr/local/lib/python3.8/site-packages/skodaconnect/vehicle.py", line 431, in set_pheater
@Farfar
Copy link
Collaborator

Farfar commented Feb 14, 2021

Yes I see it now, a missing 'f' to format the string on row 851 in connection.py.
Thanks for bringing it to my attention, will push fix.

@Farfar
Copy link
Collaborator

Farfar commented Feb 15, 2021

Latest release contain fix for this issue.

@Farfar Farfar closed this as completed Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants