Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong float-integer conversion for temp values #57

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Fix wrong float-integer conversion for temp values #57

merged 1 commit into from
Jul 4, 2022

Conversation

loeffelpan
Copy link
Contributor

@loeffelpan loeffelpan commented Jun 9, 2022

Temperature values were converted to int instead of float (e. g. 21.5 -> 21.0)
This fixes that wrong conversion and uses float instead of int.

Additionally I found some wrong exeptions messages during my tests.
skodaconnect/homeassistant-skodaconnect#122 will fix this for custom-component.

@loeffelpan
Copy link
Contributor Author

loeffelpan commented Jun 9, 2022

One thing to mention:
During my tests I tried to set climater temp with a set_timers action. It seems, that the API ignores this.
Timer was set properly but climater temp stays as before despite the request was succeeded.

Request JSON:

Request for "https://fal-3a.prd.eu.dp.vwg-connect.com/fs-car/bs/departuretimer/v1/skoda/CZ/vehicles/TMBJW9NP8L7030632/timer/actions" returned with status code [202], response: [...] , 'timerBasicSetting': {'heaterSource': 'electric', 'chargeMinLimit': '0', 'targetTemperature': '2945'}}}, 'rate_limit_remaining': '9'}

Request:

Request for "https://fal-3a.prd.eu.dp.vwg-connect.com/fs-car/bs/departuretimer/v1/skoda/CZ/vehicles/TMBJW9NP8L7030632/timer/actions/537533296" returned with status code [200], response: {'action': {'type': 'setTimersAndProfiles', 'actionId': '537533296', 'actionState': 'succeeded'}}

Response JSON:

Request for "https://fal-3a.prd.eu.dp.vwg-connect.com/fs-car/bs/climatisation/v1/skoda/CZ/vehicles/TMBJW9NP8L7030632/climater" returned with status code [200], response: {'climater': {'settings': {'targetTemperature': {'timestamp': datetime.datetime(2022, 6, 9, 9, 4, 12, tzinfo=datetime.timezone.utc), 'content': 2955}, [...]

@Farfar Farfar merged commit b933587 into skodaconnect:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants