Added all supported charging limit #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a bit reluctant to add this without further checks and limits. 0-50 is supported, afaik, on all cars. But 50+ is not which is why it's not in code yet. I also don'w know any way to tell which limit is supported or what will happen if an unsupported value is chosen. I will need to test this further. |
|
I have no good way to determine wether 50+ is supported or not and no error handling for this yet. It will be incorporated in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all supported values for min charge limit (VW maps&more and Move&Fun apps support all the values)
Tested on Skoda citgo e-iv (aka e-UP)