Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @lenra system listeners like @lenra:navTo #481

Merged
merged 4 commits into from
Oct 7, 2023
Merged

Conversation

taorepoara
Copy link
Member

@taorepoara taorepoara commented Oct 7, 2023

About this PR

Fix the @lenra:navTo system listener.

How to test my changes

Set the server branch in the server/mix.exs of the devtool:

ref: "debug-devtool"

Get the deps and build the devtool Docker image:

cd server
mix deps.get
cd ..
docker build -t lenra/devtools:local .

Try an app that uses @lenra:navTo like https://github.com/lenra-io/app-camping-des-speakers (be careful of the branch depending on this merge lenra-io/app-camping-des-speakers#38).

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@taorepoara taorepoara added the bug Something isn't working label Oct 7, 2023
@taorepoara taorepoara self-assigned this Oct 7, 2023
@taorepoara taorepoara marked this pull request as ready for review October 7, 2023 12:48
@taorepoara taorepoara mentioned this pull request Oct 7, 2023
11 tasks
Copy link
Collaborator

@jonas-martinez jonas-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no words 🥲 Nice catch ! Looks good to me !

@jonas-martinez jonas-martinez merged commit 9413176 into beta Oct 7, 2023
20 of 22 checks passed
@jonas-martinez jonas-martinez deleted the debug-devtool branch October 7, 2023 19:27
@taorepoara
Copy link
Member Author

🎉 This PR is included in version 1.0.0-beta.182 🎉

The release is available on:

Your semantic-release bot 📦🚀

@taorepoara
Copy link
Member Author

I have no words 🥲 Nice catch ! Looks good to me !

You gave me the solution on friday ;-)

@taorepoara
Copy link
Member Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants