Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Want to point out that at the moment fvm is hard to use for modular Flutter projects. #180

Closed
leoafarias opened this issue Oct 27, 2020 · 1 comment · Fixed by #181
Closed
Assignees
Labels
bug Something isn't working

Comments

@leoafarias
Copy link
Owner

Want to point out that at the moment fvm is hard to use for modular Flutter projects.

For example, even in a quite simple case (with not that many modules) like the one below, calling fvm flutter --version inside the project root and client_app would result in different versions being printed since none of the sub-projects have their own .fvm directory. The first one will print a proper project-level flutter version while the second one will print the global default flutter version.

A real-life example of a (somewhat) modular project structure (none of the sub-projects have .fvm directory):
image

I believe that it won't be hard to make fvm look for the ./fvm/flutter_sdk not only within the current directory but also within some N levels of parent directories.

This would allow for a neat flutter version scoping that, in turn, will make both the issue's case and modular project cases work well.

@leoafarias Do you see any caveats in the algorithm explained above?

Originally posted by @s0nerik in https://github.com/leoafarias/fvm/issues/151#issuecomment-717599482

@leoafarias leoafarias self-assigned this Oct 28, 2020
@leoafarias leoafarias added the bug Something isn't working label Oct 28, 2020
@s0nerik
Copy link

s0nerik commented Oct 28, 2020

Thanks a lot! Works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants