Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dark Mode #68

Closed
Wombosvideo opened this issue Aug 10, 2022 · 10 comments · Fixed by #80
Closed

Add Dark Mode #68

Wombosvideo opened this issue Aug 10, 2022 · 10 comments · Fixed by #80
Labels
Feature A new feature Good First Issue Defines a good issue for a new contributor to try

Comments

@Wombosvideo
Copy link

Is your feature request related to a problem? Please describe.
When using this app I am mostly outside in the dark and my eyes start to get red, also from the blindingly bright screen.

Describe the solution you'd like
I'd like to have an option to turn the app into dark mode which would be a little easier on the eyes.

Describe alternatives you've considered
I tried to turn down the brightness but I was still in discomfort of the brightness. Also I know there is an option "Override Force Dark" or similar, allowing to turn any app into a non-eye-straining experience but it doesn't work in this app.
Another addition could be to adapt to the phones setting, because my phone is already set to dark.

Additional context
Yes.
@Wombosvideo Wombosvideo added the Feature A new feature label Aug 10, 2022
@LeoColman LeoColman added the Good First Issue Defines a good issue for a new contributor to try label Aug 10, 2022
@LeoColman
Copy link
Owner

LeoColman commented Aug 10, 2022 •
edited
Loading

Thanks for the suggestion!
I agree, having a dark mode is a must.

@Krishpandya682
Copy link

I would like to work on this issue

@LeoColman
Copy link
Owner

Take it, @Krishpandya682 !
I think a good place for the setting is in the settings package
https://github.com/LeoColman/Petals/tree/main/app/src/main/kotlin/br/com/colman/petals/settings

The theme of the app will have to adapt in response to it, but I'm not really sure how yet. Feel free to make your ideas into a PR!

@LeoColman
Copy link
Owner

26b2746

This commit may give some insights as well

@Krishpandya682
Copy link

Hi Sorry, can you help me get started, I am unable to run the app using Android Studio

@LeoColman
Copy link
Owner

Absolutely!
What is Android studio telling you?

@LeoColman
Copy link
Owner

Hey @Krishpandya682 !
Were you able to have any advance in this issue?

@Krishpandya682
Copy link

Hi @LeoColman . Sorry I forgot to inform you but I will no longer be able to work on this issue as my computer is down. Sorry.

@LeoColman
Copy link
Owner

Don't worry!
I'm sorry about your pc.
image

LeoColman added a commit that referenced this issue Sep 6, 2022
@LeoColman
✨ Add Dark Mode following SystemDarkMode
1c492a4 
This commit leverages MaterialTheme and its integration with the system
to provide a dark theme to Petals App.

MainActivity.kt was changed to calculate if the system is set to Dark

All other files were changed to use MaterialTheme colors instead of
their default colors.

Closes #68

Signed-off-by: Leonardo Colman Lopes <dev@leonardo.colman.com.br>
@LeoColman LeoColman linked a pull request Sep 6, 2022 that will close this issue
✨ Add Dark Mode following SystemDarkMode #80
Merged
@LeoColman LeoColman mentioned this issue Sep 6, 2022
Merged
LeoColman added a commit that referenced this issue Sep 6, 2022
@LeoColman
✨ Add Dark Mode following SystemDarkMode
d2e7dfb 
This commit leverages MaterialTheme and its integration with the system
to provide a dark theme to Petals App.

MainActivity.kt was changed to calculate if the system is set to Dark

All other files were changed to use MaterialTheme colors instead of
their default colors.

Closes #68

Signed-off-by: Leonardo Colman Lopes <dev@leonardo.colman.com.br>
@LeoColman
Copy link
Owner

@Wombosvideo
I've added dark mode following system. Release 2.8.0
If needed we can also add a setting specifically to that, but I'll wait for someone to ask that before adding too many things in the settings page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature A new feature Good First Issue Defines a good issue for a new contributor to try
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Add Dark Mode following SystemDarkMode LeoColman/Petals
3 participants
@LeoColman @Wombosvideo @Krishpandya682