Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for signed expect/poke #101

Merged
merged 3 commits into from
May 20, 2019
Merged

Fix logic for signed expect/poke #101

merged 3 commits into from
May 20, 2019

Conversation

leonardt
Copy link
Owner

(based on patch-pipefail)

Fixes the logic for compiling signed values to verilator. Basically, verilator always uses the unsigned representation as a C data type, so we need to convert all negative values into their unsigned bits representation. The logic already existed, but was too conservative (it only checked if the port was type as a signed value, but there are cases where expect a signed value on an unsigned port, such as in the case of the signed mode of the PE)

@coveralls
Copy link

coveralls commented May 15, 2019

Pull Request Test Coverage Report for Build 923

  • 9 of 17 (52.94%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 76.369%

Changes Missing Coverage Covered Lines Changed/Added Lines %
fault/verilator_target.py 8 9 88.89%
fault/system_verilog_target.py 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
fault/system_verilog_target.py 1 16.29%
Totals Coverage Status
Change from base Build 919: -0.06%
Covered Lines: 1367
Relevant Lines: 1790

💛 - Coveralls

@leonardt leonardt force-pushed the patch-pipefail branch 2 times, most recently from dacd4b7 to a17e725 Compare May 15, 2019 20:37
Copy link
Collaborator

@rsetaluri rsetaluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test for this?

@leonardt leonardt changed the base branch from patch-pipefail to master May 20, 2019 15:32
@Kuree
Copy link
Collaborator

Kuree commented May 20, 2019

Is it okay to merge?

@leonardt leonardt merged commit e483dac into master May 20, 2019
@leonardt leonardt deleted the patch-signed-expect branch May 20, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants