Handling empty msgstr case

[us3r64]

If msgstr is empty msgstr "" shouldn't the original string, untranslated version, be returned?

After some tests this looks for me the right checks to handle the empty case

func (t *translation) get() string {
    // Look for translation index 0
    if _, ok := t.trs[0]; ok {
        // handle empty msgstr
        if len(t.trs[0]) == 0 {
            return t.id
        }
        return t.trs[0]
    }

    // Return unstranlated id by default
    return t.id
}

func (t *translation) getN(n int) string {
    // Look for translation index
    if _, ok := t.trs[n]; ok {
        // handle empty msgstr
        if len(t.trs[n]) == 0 {
            if len(t.pluralID) == 0 {
                return t.id
            }
            return t.pluralID
        }
        return t.trs[n]
    }

    // Return unstranlated plural by default
    return t.pluralID
}

[leonelquinteros]

You're right, as defined in https://www.gnu.org/software/gettext/manual/html_node/Untranslated-Entries.html empty translation strings should be handled as "untranslated".

I've pushed a fix for this and will do a small release for it.

Thanks for reporting!

[us3r64]

Hi,

The issue is not fixed 100%.

For GetD you do GetND with plural set to 1 but pluralID doesn't get set.

So for empty msgstr you still get "", make sense?