Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how speech bubbles get cleared and handle interruptions correctly #170

Open
towerofnix opened this issue Mar 8, 2023 · 0 comments
Open

Fix how speech bubbles get cleared and handle interruptions correctly #170

towerofnix opened this issue Mar 8, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@towerofnix
Copy link
Member

See discussion here: #146 (comment)

From @adroitwhiz:

After pondering this for a bit, I've come to the conclusion that this code has actually just been subtly broken the whole time. If another thread comes along and clears the speech bubble timeout, the done flag will never be set and we'll be stuck waiting forever.

Let's just rewrite this entirely in another PR.
@towerofnix towerofnix mentioned this issue Mar 8, 2023
Merged
@towerofnix towerofnix added the bug Something isn't working label Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@towerofnix