Skip to content
This repository has been archived by the owner on Jun 20, 2021. It is now read-only.

Browser History is spammed when you search something #157

Open
Kreijstal opened this issue Mar 4, 2019 · 2 comments
Open

Browser History is spammed when you search something #157

Kreijstal opened this issue Mar 4, 2019 · 2 comments

Comments

@Kreijstal
Copy link

  1. Go to https://tldr.ostera.io/
  2. Search something by typping it
  3. Look at the history log
    When you search for a command on the web frontend, every keystroke you type is pushed to the browser history so your history is cluttered with every key, you just typed.
@sbrl
Copy link
Contributor

sbrl commented Jan 4, 2021

Looks like instead of updating the location object directly, if navigation is done with the Web History API via history.replaceState, that would solve this issue.

@sbrl
Copy link
Contributor

sbrl commented Jan 4, 2021

As @mebiem suggests, perhaps a new state could be pushed only when a page is actually found?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants