Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[experimental codegen] Only hermes-engine pod outdated per RN upg #825

Closed
leotm opened this issue Aug 6, 2022 · 0 comments · Fixed by #1012
Closed

[experimental codegen] Only hermes-engine pod outdated per RN upg #825

leotm opened this issue Aug 6, 2022 · 0 comments · Fixed by #1012
Labels
ci GitHub Actions workflow - Bundling / Building / Compiling / Integrating / Testing cocoapods CocoaPods changes for building iOS and tvOS hermes JS engine for RN (optimised: TTI, size, RAM) ios Native iOS changes (Swift, C++, CocoaPods) p: Facebook Partner: Meta react native react-native-community.github.io/upgrade-helper 🧪 Experimental

Comments

@leotm
Copy link
Owner

leotm commented Aug 6, 2022

tl;dr pod install fails each RN upg from OOD Hermes


Example

# ...
[Codegen] Done.
Analyzing dependencies
Fetching podspec for `DoubleConversion` from `../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`
Fetching podspec for `RCT-Folly` from `../node_modules/react-native/third-party-podspecs/RCT-Folly.podspec`
Fetching podspec for `boost` from `../node_modules/react-native/third-party-podspecs/boost.podspec`
Fetching podspec for `glog` from `../node_modules/react-native/third-party-podspecs/glog.podspec`
Fetching podspec for `hermes-engine` from `../node_modules/react-native/sdks/hermes/hermes-engine.podspec`

Adding spec repo `trunk` with CDN `[https://cdn.cocoapods.org/`](https://cdn.cocoapods.org/%60)
[!] [Codegen] warn: using experimental new codegen integration
[!] CocoaPods could not find compatible versions for pod "hermes-engine":
  In snapshot (Podfile.lock):

    hermes-engine (from `../node_modules/react-native/sdks/hermes/hermes-engine.podspec`)
[!] [Deprecated] You are using the old `libraries` array to list all your codegen.\nThis method will be removed in the future.\nUpdate your `package.json` with a single object.

  In Podfile:
    hermes-engine (from `../node_modules/react-native/sdks/hermes/hermes-engine.podspec`)

It seems like you've changed the version of the dependency `hermes-engine` and it differs from the version stored in `Pods/Local Podspecs`.
You should run `pod update hermes-engine --no-repo-update` to apply changes made locally.
Error: Process completed with exit code 1.

pod update hermes-engine --no-repo-update shouldn't be required each time, jus like other pods don't

pos regression from bundled hermes?

will this fix? or is this where to fix itit via Yarn v3 patch?


Happening again

pod install forgets to update - hermes-engine (0.70.0-rc.2) to - hermes-engine (0.70.0-rc.3)

@leotm leotm added hermes JS engine for RN (optimised: TTI, size, RAM) ios Native iOS changes (Swift, C++, CocoaPods) react native react-native-community.github.io/upgrade-helper ci GitHub Actions workflow - Bundling / Building / Compiling / Integrating / Testing p: Facebook Partner: Meta 🧪 Experimental labels Aug 6, 2022
@leotm leotm added this to the React Native 0.70 milestone Aug 6, 2022
@leotm leotm added the cocoapods CocoaPods changes for building iOS and tvOS label Aug 6, 2022
leotm added a commit that referenced this issue Aug 7, 2022
leotm added a commit that referenced this issue Aug 8, 2022
leotm added a commit that referenced this issue Aug 8, 2022
leotm added a commit that referenced this issue Aug 8, 2022
Note: #825

Then merge immediately since Renovate keeps force pushing 0.70.0-rc.1 before CI finishes, or tweak config
leotm added a commit that referenced this issue Aug 8, 2022
* Update react-native monorepo

* Update RN pods from 0.70.0-rc.1 to 0.70.0-rc.2

Note: #825

Then merge immediately since Renovate keeps force pushing 0.70.0-rc.1 before CI finishes, or tweak config

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
@leotm leotm added this to In progress in 1337 - Template+ Aug 10, 2022
leotm added a commit that referenced this issue Aug 24, 2022
leotm added a commit that referenced this issue Aug 25, 2022
* Update dependency react-native to v0.70.0-rc.4

* Update gitignore .cxx

Code review feedback
- facebook/react-native#34430

* Update react-native pods to v0.70.0-rc.4

* Remove stale _editorconfig

- looks like for Windows
- not in `main` /template

* Update pod hermes-engine to 0.70.0-rc.4

#825

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: LeoTM <1881059+leotm@users.noreply.github.com>
leotm added a commit that referenced this issue Sep 25, 2022
Skip updating spec repo pre-install

Fix: #825
1337 - Template+ automation moved this from In progress to Done Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci GitHub Actions workflow - Bundling / Building / Compiling / Integrating / Testing cocoapods CocoaPods changes for building iOS and tvOS hermes JS engine for RN (optimised: TTI, size, RAM) ios Native iOS changes (Swift, C++, CocoaPods) p: Facebook Partner: Meta react native react-native-community.github.io/upgrade-helper 🧪 Experimental
Projects
Development

Successfully merging a pull request may close this issue.

1 participant