Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-native monorepo (patch) #815

Merged
merged 2 commits into from Aug 8, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 2, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react-native (changelog) 0.70.0-rc.1 -> 0.70.0-rc.2 age adoption passing confidence
react-native-gradle-plugin 0.70.0 -> 0.70.1 age adoption passing confidence

Release Notes

facebook/react-native

v0.70.0-rc.2

Compare Source

To try it, run:

npx react-native init RN070RC2 --version 0.70.0-rc.2


  • You can participate in the conversation on the status of this release in the working group

  • To help you upgrade to this version, you can use the upgrade helper ⚛️

  • The full list of changes in release can read in the changelog PR


Help us testing 🧪

We need your help testing one feature in particular with this RC (autolinking of TurboModules from libraries)! Here is what you have to do:

  1. generate a new app (as per command above)

  2. turn on the new architecture:

    1. iOS
      1. cd ios
      2. bundle install && RCT_NEW_ARCH_ENABLED=1 bundle exec pod install(or RCT_NEW_ARCH_ENABLED=1 pod install)
      3. cd ..
      4. yarn ios
    2. Android
      1. go into gradle.properties
      2. switch the flag newArchEnabled to true
      3. yarn android
    3. verify that the app is running new arch by checking the Metro log for something along the lines of LOG Running "RN070RC1" with {"fabric":true,"initialProps":{"concurrentRoot":true},"rootTag":1}
  3. add a library that has the new TM implementation (such as https://github.com/th3rdwave/react-native-safe-area-context) via yarn add <lib>

  4. rerun the app again (remember to do a new RCT_NEW_ARCH_ENABLED=1 pod install for iOS), verify that the lib added works correctly

  5. check in the file android/app/build/generated/rncli/src/main/jni/Android-rncli.mk that there's a reference to the library added, something along the lines of
    include /node_modules/react-native-safe-area-context/android/build/generated/source/codegen/jni/Android.mk

    import-codegen-modules := \
      libreact_codegen_safeareacontext
    
  6. let us know how it went by posting a comment in the working group discussion! Please specify with system you tried it on (ex. macos, windows).

Bonus points: It would be even better if you could swap things around: instead of using a fresh new app, use a more complex one - or use a different library that is already leveraging the new architecture!


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added deps Normal dependencies needed at runtime react native react-native-community.github.io/upgrade-helper labels Aug 2, 2022
@renovate renovate bot force-pushed the renovate/patch-react-native-monorepo branch from 17b8d60 to 9770da5 Compare August 4, 2022 17:42
@renovate renovate bot changed the title Update dependency react-native-gradle-plugin to v0.70.1 Update react-native monorepo (patch) Aug 4, 2022
@renovate renovate bot force-pushed the renovate/patch-react-native-monorepo branch 3 times, most recently from 1dd7089 to 8a76ddc Compare August 6, 2022 06:58
@leotm leotm linked an issue Aug 7, 2022 that may be closed by this pull request
@leotm leotm modified the milestone: React Native 0.70 Aug 7, 2022
@renovate renovate bot force-pushed the renovate/patch-react-native-monorepo branch 9 times, most recently from 9151c1e to 9a787f4 Compare August 8, 2022 07:51
@renovate renovate bot force-pushed the renovate/patch-react-native-monorepo branch from a93ee36 to 8326d14 Compare August 8, 2022 08:51
Note: #825

Then merge immediately since Renovate keeps force pushing 0.70.0-rc.1 before CI finishes, or tweak config
@leotm leotm merged commit 343c785 into master Aug 8, 2022
@leotm leotm deleted the renovate/patch-react-native-monorepo branch August 8, 2022 08:58
@leotm leotm added this to the React Native 0.70 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Normal dependencies needed at runtime react native react-native-community.github.io/upgrade-helper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.70.0-rc.2
1 participant