-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canary issue? #38
Comments
Can confirm the same issue on OS X. Looks like Discord changed where the ➜ ~ beautifuldiscord --css theme.css
Found Discord Canary under /Applications/Discord Canary.app/Contents/MacOS
WARNING: app.asar not found
Done!
You may now edit your /Users/shikhirarora/theme.css file,
which will be reloaded whenever it's saved.
Relaunching Discord now... |
The change was reverted so you shouldn't use that branch. |
Hey @Rapptz -- appears to have come back as of the just latest update on canary. [BUILD INFO] Release Channel: canary, Build Number: 8829, Version Hash: dc95517d7e4f4754019a1be9446c540829f37f4d 2017-12-18 19:09:32.517 They just pushed another canary update and it seems to not work on macOS. I've tried reinstalling and using both the ➜ ~ python3 -m beautifuldiscord --css theme.css
0: Found Discord PTB
1: Found Discord Canary
Discord executable to use (number): 1
WARNING: app.asar not found
Traceback (most recent call last):
File "/usr/local/Cellar/python3/3.6.2/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 193, in _run_module_as_main
"__main__", mod_spec)
File "/usr/local/Cellar/python3/3.6.2/Frameworks/Python.framework/Versions/3.6/lib/python3.6/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.6/site-packages/beautifuldiscord/__main__.py", line 3, in <module>
main()
File "/usr/local/lib/python3.6/site-packages/beautifuldiscord/app.py", line 233, in main
with open('./app/index.js', 'r', encoding='utf-8') as f:
FileNotFoundError: [Errno 2] No such file or directory: './app/index.js' ➜ ~ beautifuldiscord --css theme.css
0: Found Discord Canary
1: Found Discord PTB
Discord executable to use (number): 0
Couldn't copy file ./node_modules/.bin/har-validator, no extracted directory
Couldn't copy file ./node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/.bin/mkdirp, no extracted directory
Couldn't copy file ./node_modules/.bin/rimraf, no extracted directory
Couldn't copy file ./node_modules/.bin/sshpk-conv, no extracted directory
Couldn't copy file ./node_modules/.bin/sshpk-sign, no extracted directory
Couldn't copy file ./node_modules/.bin/sshpk-verify, no extracted directory
Couldn't copy file ./node_modules/.bin/uuid, no extracted directory
Couldn't copy file ./node_modules/create-react-class/node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/fbjs/node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/http-signature/node_modules/.bin/sshpk-conv, no extracted directory
Couldn't copy file ./node_modules/http-signature/node_modules/.bin/sshpk-sign, no extracted directory
Couldn't copy file ./node_modules/http-signature/node_modules/.bin/sshpk-verify, no extracted directory
Couldn't copy file ./node_modules/prop-types/node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/react/node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/react-dom/node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/request/node_modules/.bin/har-validator, no extracted directory
Couldn't copy file ./node_modules/request/node_modules/.bin/uuid, no extracted directory
Traceback (most recent call last):
File "/usr/local/bin/beautifuldiscord", line 11, in <module>
load_entry_point('BeautifulDiscord==0.1.0', 'console_scripts', 'beautifuldiscord')()
File "/usr/local/lib/python3.6/site-packages/beautifuldiscord/app.py", line 233, in main
with open('./app/index.js', 'r', encoding='utf-8') as f:
FileNotFoundError: [Errno 2] No such file or directory: './app/index.js' |
That's not the |
Thanks for fixing it so fast/pointing that out, forgot to pull the right branch -- my mistake. |
Seems like we hopefully have a more permanent change this time. The folders that were in the |
Not exactly, since the |
I noticed that also and expected this to not work, but I had no troubles making the above modifications. I extracted Will probably need a revert function of some sort like before, but I'm not sure how this folder will be handled in updates. Previously, all of these folders were completely cleared out in the config dir on each server side update, so hopefully that continues to happen. Otherwise, there could potentially be errors on each server side update. |
When did you get that error? I've been using the client with the above modifications for a couple of hours now with no errors. Might just be a thing that works on Linux? FWIW, I tried connecting to VC, restarting the app multiple times, etc and everything seems to be working as expected. :EDIT: Just thinking maybe you didn't extract core.asar in the way it expects? Here's a screenshot of my |
Doesn't matter much -- I've already fixed it by just repacking the asar file when I finish modifying it. I've also added preliminary Linux support based on what people have told me. If it works please let me know (or if it stops working) @simoniz0r |
@Rapptz Doesn't seem to be able to find the directory:
|
You mind giving me the results of |
[REDACTED] |
|
Can confirm it does work on macOS with the latest canary, albeit giving some [BUILD INFO] Release Channel: canary, Build Number: 8933, Version Hash: 853d8a4b384a443599a4b9349ce7aaa10dbf8a26
2017-12-20 02:34:04.649 ➜ ~ python3 -m pip install -U https://github.com/leovoel/BeautifulDiscord/archive/canary.zip
Collecting https://github.com/leovoel/BeautifulDiscord/archive/canary.zip
Downloading https://github.com/leovoel/BeautifulDiscord/archive/canary.zip
\ 20kB 3.2MB/s
Requirement already up-to-date: psutil in /usr/local/lib/python3.6/site-packages (from BeautifulDiscord==0.1.0)
Installing collected packages: BeautifulDiscord
Found existing installation: BeautifulDiscord 0.1.0
Uninstalling BeautifulDiscord-0.1.0:
Successfully uninstalled BeautifulDiscord-0.1.0
Running setup.py install for BeautifulDiscord ... done
Successfully installed BeautifulDiscord-0.1.0
➜ ~ beautifuldiscord --css theme3.css
0: Found Discord Canary
1: Found Discord PTB
Discord executable to use (number): 0
Couldn't copy file ./node_modules/.bin/har-validator, no extracted directory
Couldn't copy file ./node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/.bin/mkdirp, no extracted directory
Couldn't copy file ./node_modules/.bin/rimraf, no extracted directory
Couldn't copy file ./node_modules/.bin/sshpk-conv, no extracted directory
Couldn't copy file ./node_modules/.bin/sshpk-sign, no extracted directory
Couldn't copy file ./node_modules/.bin/sshpk-verify, no extracted directory
Couldn't copy file ./node_modules/.bin/uuid, no extracted directory
Couldn't copy file ./node_modules/create-react-class/node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/fbjs/node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/http-signature/node_modules/.bin/sshpk-conv, no extracted directory
Couldn't copy file ./node_modules/http-signature/node_modules/.bin/sshpk-sign, no extracted directory
Couldn't copy file ./node_modules/http-signature/node_modules/.bin/sshpk-verify, no extracted directory
Couldn't copy file ./node_modules/prop-types/node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/react/node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/react-dom/node_modules/.bin/loose-envify, no extracted directory
Couldn't copy file ./node_modules/request/node_modules/.bin/har-validator, no extracted directory
Couldn't copy file ./node_modules/request/node_modules/.bin/uuid, no extracted directory
Done!
You may now edit your /Users/shikhirarora/theme3.css file,
which will be reloaded whenever it's saved.
Thanks @Rapptz 👍 |
@sansation Thanks! I think it should be fixed now. |
Yep, that issue is fixed now. The only problem is that since I'm on Arch, there's no way to easily apply the CSS. Before, I could use |
Ideally you should no longer need root. Since the only writing it's doing should reside strictly inside |
|
I thought I moved that over to a home directory but I didn't. I'll make sure to fix. |
Should be fixed now. It makes the file over to I think in the future it should just be a regular cssInjection.js file in the root BD directory and then use that to save the writing etc. But for now this is good enough. |
So I have tried to install BeautifulDiscord from the Canary branch, however it stopped to work today at 17. September 2017. Here's an image of the error it output
I have tested from both C:\ and G:\ (Just to make sure it's not different partition issue, but the same error displays regardless.
Here's an image of the folder it searches, noticed that discord_desktop_core is not located here. In case of wonder, I have tried to reinstall Discord Canary to check.
Thanks in advance
-- AlexFlipnote
The text was updated successfully, but these errors were encountered: