Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop withhold_token before making request #47

Closed
davidism opened this issue Apr 24, 2018 · 1 comment
Closed

pop withhold_token before making request #47

davidism opened this issue Apr 24, 2018 · 1 comment

Comments

@davidism
Copy link

davidism commented Apr 24, 2018

In OAuthClient.request, the withhold_token arg appears to be internal, but it is passed on as a param in the request.

if kwargs.get('withhold_token'):
return session.request(method, url, **kwargs)

Should this be popped?

if kwargs.pop('withhold_token', False):
    return session.request(method, url, **kwargs)
@davidism
Copy link
Author

My mistake, I thought this was going directly to request.Session, but it's going to OAuth2Session(request.Session).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant