Add --allow-branch option to restrict publish to designated branches #1026
Conversation
|
whoops, sorry, the integration tests seem to be borked :/ |
|
I guess jestjs/jest#3584 is what is causing it, right? So I will rollback the jest version |
package.json
Outdated
| @@ -81,7 +81,7 @@ | |||
| "eslint-plugin-flowtype": "^2.35.0", | |||
| "eslint-plugin-node": "^5.1.1", | |||
| "file-url": "^2.0.2", | |||
| "jest": "^19.0.2", | |||
| "jest": "^21.1.0", | |||
There was a problem hiding this comment.
oh, yeah, please don't change this? It's being held back for a reason (I haven't had time to figure out why jest 20+ breaks)
|
basically, yeah. I haven't had time to knit the integration tests back into the regular tests (as well as make them take less time) |
README.md
Outdated
| } | ||
| ``` | ||
|
|
||
| and you are not on the branch `my-new-feature` currently lerna will prevent you from publishing. To force a publish anyways you can use |
There was a problem hiding this comment.
This should read
and you are not on the branch `master`, lerna will prevent you from publishing.
To force a publish despite this config, pass the `--allow-branch` flag:
and so on
src/commands/PublishCommand.js
Outdated
| @@ -206,6 +214,12 @@ export default class PublishCommand extends Command { | |||
| throw new Error("Detached git HEAD, please checkout a branch to publish changes."); | |||
| } | |||
|
|
|||
| const currentBranch = GitUtilities.getCurrentBranch(this.execOpts); | |||
| if (this.options.allowBranch && !minimatch(currentBranch, this.options.allowBranch)) { | |||
| throw new Error('Branch ' + currentBranch + ' is not allowed to be published. ' + | |||
There was a problem hiding this comment.
Should be able to use dedent with multi-line template strings, here.
|
@evocateur could you take a look again? I hope I fixed everything :) |
|
Looks great! |
evocateur
changed the title
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
As suggested in #1007 this introduces an
allow-branchflag to thepublishcommand.Motivation and Context
As above, I would like to use that feature too.
How Has This Been Tested?
Test suite & manual in another project
Types of changes
Checklist: