Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable npm publish on all non-master branches #1963

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 3, 2017

Issue: N/A

What I did

Use Lerna's new allowBranch feature to disable publishing on non-master banches to prevent mistakes

lerna/lerna#1026

How to test

Run the following on a non-master branch:

yarn lerna publish --skip-git --skip-npm --npm-tag=block

@Hypnosphi Hypnosphi self-assigned this Oct 3, 2017
@shilman shilman requested a review from Hypnosphi October 3, 2017 22:36
@codecov
Copy link

codecov bot commented Oct 3, 2017

Codecov Report

Merging #1963 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1963   +/-   ##
=======================================
  Coverage   21.38%   21.38%           
=======================================
  Files         262      262           
  Lines        5757     5757           
  Branches      683      689    +6     
=======================================
  Hits         1231     1231           
+ Misses       4011     4005    -6     
- Partials      515      521    +6
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 47.36% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdf523...fdce4c9. Read the comment docs.

@Hypnosphi Hypnosphi merged commit fa507d0 into master Oct 3, 2017
@shilman shilman deleted the shilman/publish-on-release-branch branch October 3, 2017 22:59
@shilman shilman changed the title Disable nom publish on all non-master branches to prevent mistakes Disable npm publish on all non-master branches to prevent mistakes Oct 3, 2017
@shilman shilman changed the title Disable npm publish on all non-master branches to prevent mistakes Disable nom publish on all non-master branches Oct 3, 2017
@shilman shilman changed the title Disable nom publish on all non-master branches Disable npm publish on all non-master branches Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants