Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloadable files #202

Closed
danielstreif opened this issue Oct 28, 2019 · 3 comments · Fixed by #203
Closed

Downloadable files #202

danielstreif opened this issue Oct 28, 2019 · 3 comments · Fixed by #203
Assignees
@danielstreif
Labels
don't merge Do not merge. invalid This doesn't seem right

Comments

@danielstreif
Copy link
Collaborator

Problem description:
The download links for the pdf documents "Satzung" and "Mitgliedsantrag" lead to strikingly. Right now they still work but we should move the files to another location to be independent of strikingly.

Suggested solution:
Upload the files on MongoDB or another location and change the link paths accordingly.
@danielstreif danielstreif added the invalid This doesn't seem right label Oct 28, 2019
@pheeria
Copy link
Member

pheeria commented Oct 28, 2019

Let's move them to data or static directory?
As far as I know MongoDB is a json based database, it would be not very handy to serialize/deserialize the file to binary.

@jarjan
Copy link
Member

jarjan commented Oct 28, 2019

We can put in inside static in some folder, make a link with download attribute, this way browser will download it.
Here is more: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#attr-download

@danielstreif danielstreif mentioned this issue Oct 28, 2019
Merged
3 tasks
@danielstreif danielstreif self-assigned this Oct 28, 2019
@danielstreif danielstreif added the don't merge Do not merge. label Oct 28, 2019
@pheeria
Copy link
Member

pheeria commented Oct 28, 2019

This is a really good catch, @hikes101!
Thank you for being attentive! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielstreif danielstreif

Labels
don't merge Do not merge. invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

move download files Lernwerkstatt/site
3 participants
@jarjan @pheeria @danielstreif