(WIP) V3 #133
Closed
(WIP) V3 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravanscafi
force-pushed
the
v3
branch
2 times, most recently
from
7c9d605
to
0e28529
Compare
The PHP driver uses libmongoc's single-threaded client mode, which does not implement connection pools. There is also no way to implement your own connection pooling using this driver. Each single-threaded libmongoc client object maintains at most one socket connection per mongod or mongos server. The relationship between MongoDB\Driver\Manager objects and libmongoc client objects is discussed in Connection Handling in the driver documentation. Connection pools should not be needed for any single-threaded application, unless you're using an async PHP framework (e.g. Amp, ReactPHP). In those cases, you'd probably need to implement your own driver as we provide no way to integrate libmongoc's IO with a PHP event loop. Multi-threaded PHP applications (e.g. pthreads, forking) are not supported by the driver. mongodb/mongo-php-driver#688 (comment)
added 2 commits
November 30, 2018 09:23
This improves testing timestamps and id generation on applications using mongolid.
|
@ravanscafi What about implementing a |
ravanscafi
commented
Feb 1, 2019
| public function syncOriginalDocumentAttributes() | ||
| { | ||
| try { | ||
| $this->originalAttributes = unserialize(serialize($this->getDocumentAttributes())); |
There was a problem hiding this comment.
note to self: this takes way too many memory, think about alternatives or drop it altogether.
|
|
||
| - PHP**7** | ||
| ## Requirements | ||
| - PHP **7.1** or superior |
There was a problem hiding this comment.
Suggested change
| - PHP **7.1** or superior | |
| - PHP **7.1** or higher |
Merged
* Upgrade illuminate dependencies This upgrade is necessary to make mongolid compatible with laravel 7 * Revert "Upgrade illuminate dependencies" This reverts commit ea0df63. * Add Illuminate ^7.26 dependencies Add Illuminate ^7.26 dependencies * Revert "Add Illuminate ^7.26 dependencies" This reverts commit e2ffe3a. * Add Illuminate 7 dependencies
Replace Sami by Doctum
docs: remove typos from README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To-do
pool(see php mongodb connect pool mongodb/mongo-php-driver#688 (comment))updatemethod (including Unsetting a field and updating the model has no effect #122)nullattributesby other fieldfirstqueries withnullcreated_atandupdated_atmanagement on embedded relationsCursorandCacheableCursor(Review Cursor and CacheableCursor #115)DataMapperas it does not follow Data Mapper pattern correctly (perhaps drop it?)Serializable/Unserializableclasses on saving/retrieving objects implementing Persistable.ModelInterfaceDependent Packages
Maybe (not breaking changes, so that can be implemented later)
refresh()(Native way to refresh a model #40)complete()/incomplete()and saving exceptions (for models retrieved with projections)has,is, etc.)