Use LMBR Coding Standard #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carusogabriel
requested review from
diegofelix,
Zizaco,
vitorbari and
ravanscafi
vitorbari
reviewed
Oct 17, 2018
| $entity->where(); | ||
| } | ||
|
|
||
| public function testShouldGetCollectionName() | ||
| { | ||
| $entity = new class() extends ActiveRecord { | ||
| /** |
There was a problem hiding this comment.
Can this rule be disabled for anonymous classes or tests directory ?
There was a problem hiding this comment.
@ravanscafi What do you think?
There was a problem hiding this comment.
@kukulich Maybe we can add an option for that for SlevomatCodingStandard.TypeHints.TypeHintDeclaration?
There was a problem hiding this comment.
I need to solve slevomat/coding-standard#353 first.
ravanscafi
approved these changes
Oct 18, 2018
ravanscafi
force-pushed
the
coding-standard
branch
from
6a62069
to
3f93cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.