Skip to content

Commit

Permalink
Add new elements for code repo and code bugs, see #68
Browse files Browse the repository at this point in the history
  • Loading branch information
@Synchro
Synchro committed Jan 2, 2014
1 parent 72aeef5 commit e5b8b4c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
2 changes: 2 additions & 0 deletions _config.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ issues: <%= pkg.bugs.url %>?&state=open
download:
source: <%= pkg.homepages %>/archive/master.zip
latest: https://raw.github.com/less/less.js/master/dist/less-<%= less.version %>.min.js
coderepo: <%= pkg.coderepository.url %>
codeissues: <%= pkg.codebugs.url %>?&state=open

This comment has been minimized.

Sign in to view

Copy link
@jonschlinkert

jonschlinkert Jan 2, 2014

Contributor

@Synchro these custom variables should probably just be directly defined here, in _config.yml, instead of by reference, unless we want to use them in the templates with {{pkg.coderepository.url}} as well. I guess it's 6 to one, half-dozen to another

This comment has been minimized.

Sign in to view

Copy link
@Synchro

Synchro Jan 2, 2014

Author Member

Indeed. I was trying to be consistent, but on the other hand it's not as if this repo is likely to ever be used for anything else. Want me to change it to go that way?

This comment has been minimized.

Sign in to view

Copy link
@jonschlinkert

jonschlinkert Jan 2, 2014

Contributor

I see your point, it definitely is more consistent based on the existing pattern. really there is no rush, the links aren't doing any harm in the package.json.

I used to use a mixture of both {{pkg.foo}} and {{site.foo}} for passing config data to the templates, but it gets a little harder to maintain after a while (versus using one context). So I started using just site (which is from _config.yml, I know strange. but it's a Jekyll convention. I caved in a couple months ago and started using it since a lot of GitHub users are familiar and comfortable with it).

If you're interested, I'd love to give you a walkthrough of assemble sometime (@doowb and I are going to be on js-jabber in Feb to talk about 0.5.0 too!)

cdn:
cloudflare: //cdnjs.cloudflare.com/ajax/libs/less.js/1.5.0/less.min.js
Expand Down
7 changes: 7 additions & 0 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@
"bugs": {
"url": "https://github.com/less/less-docs/issues"
},
"coderepository": {
"type": "git",
"url": "https://github.com/less/less.js.git"
},
"codebugs": {
"url": "https://github.com/less/less.js/issues"
},
"licenses": [
{
"type": "MIT",
Expand Down
4 changes: 2 additions & 2 deletions templates/includes/nav-main.hbs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
<li> <a href="{{site.repo}}">Docs Repo</a> </li>
<li> <a href="{{site.issues}}">Docs Issues</a> </li>
<li class="divider"></li>
<li> <a href="{{site.repo}}">Less.js Repo</a> </li>
<li> <a href="{{site.issues}}">Less.js Issues</a> </li>
<li> <a href="{{site.coderepo}}">Less.js Repo</a> </li>
<li> <a href="{{site.codeissues}}">Less.js Issues</a> </li>
</ul>
</li>
</ul>
Expand Down

0 comments on commit e5b8b4c

Please sign in to comment.