Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The github drop down links don't work #68

Closed
lukeapage opened this issue Jan 2, 2014 · 6 comments
Closed

The github drop down links don't work #68

lukeapage opened this issue Jan 2, 2014 · 6 comments

Comments

@lukeapage
Copy link
Member

No description provided.

Synchro added a commit to Synchro/less-docs that referenced this issue Jan 2, 2014
@Synchro
Fix for less#68, github links don't work
72aeef5
@Synchro
Copy link
Member

Synchro commented Jan 2, 2014

Getting to grips with assemble! I also see that the markup for the github links is the same for less and less-docs, so that needs fixing too. I'm not sure of the best way to do that - extend pkg.repository and pkg.bugs to have code and docs parts? Or create new docsrepository and docsbugs elements?

@Synchro
Copy link
Member

Synchro commented Jan 2, 2014

Why wasn't this push linked to this ticket?

Synchro added a commit that referenced this issue Jan 2, 2014
@Synchro
Add new elements for code repo and code bugs, see #68
e5b8b4c
@Synchro
Copy link
Member

Synchro commented Jan 2, 2014

Earlier comment was wrong way around - this is the docs repo so I needed to add separate elements for code parts. Anyway, all links are working now.

@Synchro Synchro closed this as completed Jan 2, 2014
@jonschlinkert
Copy link
Contributor

Regarding the links, we could just hard-code the links in here https://github.com/less/less-docs/blob/master/templates/includes/nav-main.hbs#L46-L50, or we can add/update variables in _config.yml.

btw, I realized a couple days ago that Foundation is using Assemble for their docs too. IMHO they have some really nice conventions for how things are organized in that project.

@jonschlinkert
Copy link
Contributor

Oh I just realized you pushed up while I was writing...

@jonschlinkert
Copy link
Contributor

@lukeapage yesterday I did a double take after clicking away from a less.js issue that had been closed. I thought, "wait... who was that guy closing one of Luke's issues on less.js? I've never seen... oh it is Luke!". Lol, true story

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Synchro @lukeapage @jonschlinkert