Nested parent selectors &:not(&) - 2026

[SomMeri]

Related to #2026 - nested parent selectors.

E.g. parent selector in following code should be replaced:

.foo {
    .selector:not(&_bar) {
        color:red;
    }
}

and compile into:

.foo {
    .selector:not(.foo_bar) {
        color:red;
    }
}

[lukeapage]

[edit] extra space - its less, so just needs tidying

[lukeapage]

Congratulations on editing that code - I wrote it originally and I still find it daunting any time I have to go back and make changes, it takes time to understand. Thanks for adding the comments. Any chance you could add a comment in this PR on roughly what you changed? I've spent a while looking at it and get the basic concept, but I'm a little lost on what has changed and what hasn't.

If you don't have time to do the tidyups, I can do that after pulling.

[SomMeri]

This is the new part and it calls this new function. The rest is mostly extracting pieces of code into functions and renaming variables.

New functions: replaceParentSelector contains mostly code that used to be inlined. E.g. it was called only from one place after I extracted it. The same with addReplacementIntoPath and addAllReplacementsIntoPath.

The change is in replaceParentSelector. It used to loop through all selector elements. Parent selectors & were replaced and everything else was left as is. It did not worked correctly, because this &:not(&) is parsed into three elements array with elements being:

• &
• :not
• parenthesis(selector(elements:[&]))

So, it would look at parenthesis(selector(elements:[&])), conclude it is not parent selector and leave it alone. Find selector function looks for such structures. If it is found, new code calls replaceParentSelector recursively on found nested selector.

The last step is to pack it all back into parenthesis+selector and store into newSelectors so it can be added into paths the same way as normal parent selector replacement.

[SomMeri]

@lukeapage I modified the pull request. Changes:

• merged less.js master changes,
• fixed spacing and commented code,
• fixed one more bug - multiple rulesets nestings.

[lukeapage]

Sorry about whitspace merging! Hope it wasnt too painfull.. I started
noticing quite varied coding styles..

[SomMeri]

I did not noticed. Git apparently handled that fine :)