Implemented named arguments

[jamesfoster]

Hey Alexis,

Here's an implementation of named parameters. For example:

.mixin(@a: 1, @b: 2, @c: 3, @d: 4, @e: 5) {
  ...
}

.class {
  .mixin(1, 2, 3, 4, 10);
  .mixin(@e: 10);
}

If you wanted to override the 5th argument you would need to know the default value for the first 4 before supplying the 5th and if the defaults changed you now have to find everywhere where you've done this.

Not good.

Now you just specify the name of the argument you want to override.

It might be nice to throw an error if you place any named arguments before any "positional" arguments. as it stands it works regardless but you may get unexpected results.

Cheers

James

[paulyoung]

This is great!

[arharp]

Yeah, this looks awesome.

[dimensia]

Nice!

[jamesfoster]

This should really be a second pull request. Just "fully" implemented the & parent selector.

Enjoy

[paulyoung]

Another killer feature!

Here's the usage. This:

#box {
    #other-box {
        margin: 10px 0 0;
    }
}

.ie7 {
    #box {
        #other-box {
            margin: 5px 0 0;
        }
    }
}

Becomes:

#box {
    #other-box {
        margin: 10px 0 0;

        .ie7 & {
            margin: 5px 0 0;
        }
    }
}

This removes the need for duplicate rules in separate blocks, and also overcomes the need to match the structure exactly within those blocks to overcome specificity issues. e.g. This wouldn't have worked for the above:

.ie7 {
    #other-box {
        margin: 5px 0 0;
    }
}

Nice work!

[jamesfoster]

Just rebased to make it easier to merge. Also squashed the named arguments feature into a single commit.

Original branch at jamesfoster@req268

[revolunet]

OMG +1 great work

[cowboyd]

This has been on my wish list for a very long time, and I'd love to see it in one form or another.

[thatdutchguy]

Do want

[leeoniya]

+1

[Evgenus]

+1

[chelmertz]

+1

[oknoway]

Hard to think of anything I've wanted more than a parent selector. Great work!

[joeldbirch]

Really looking forward to being able to use this.

[jamesfoster]

Thanks for all the comments. This is one of those things I've wanted for a while myself too. my friend brought it up some time later and the solution just hit me.

Not sure what's holding up the merge but @cloudhead assures me it's coming.

[csnover]

773229f applies cleanly against the current master but does not work (causes a JS error); 2e042e9 applies and works fine. I wonder if it would be easier to get this landed if it’s split into two pull reqs?

[jamesfoster]

ok. thanks for this. I'll split the requests up and add the above case to the tests and fix it.

[cowboyd]

@jamesfoster Your parent selector fixes were merged, but did you ever resubmit the named parameters enhancement. I really, really, really think that this is a killer feature, and deserves another PR.

[Spaxe]

Any progress on this ticket?

[paulyoung]

Would love to see named arguments added.

[donaldharvey]

Currently working on an updated version of this here; will be submitting another pull request after I've tested it a bit more thoroughly.

[regisphilibert]

Woah, I'm tweeting this, cheers mate!

[geddski]

What ever happened to this? I found myself needing named arguments and wishing LESS had it. Seeing a pull request open for a year that has it is pretty frustrating. I see why people are switching to stylus/sass.

[jamesfoster]

Rebased and fixed issue with trailing space.

[ursbraem]

+1

[yanneves]

+1