Bootstrap 3 fails to compile #432

aristath · 2013-06-03T00:22:44Z

Bootstrap 3 broke on this commit: twbs/bootstrap@60575df#diff-3
The problem is on line 253 of the mixins.less file there, but I can't figure out what it is..

The text was updated successfully, but these errors were encountered:

krnlde · 2013-06-05T08:36:14Z

It's the parameter list of the gradients mixins, because they are now separated with semicolons instead of commas.
I don't know why, but it seems that you now have the ability to omit parameters in the middle. (similar to messages in Obj-C)

krnlde · 2013-06-05T11:25:10Z

Got it. http://lesscss.org/#-parametric-mixins says:
Mixins With Multiple Parameters

Parameters are either semicolon or comma separated. It is recommended to use semicolon. The symbol comma has double meaning: it can be interpreted either as a mixin parameters separator or css list separator.

Using comma as mixin separator makes it impossible to create comma separated lists as an argument. On the other hand, if the compiler sees at least one semicolon inside mixin call or declaration, it assumes that arguments are separated by semicolons and all commas belong to css lists:

Maybe the solution is in the $delim variable in here: https://github.com/leafo/lessphp/blob/master/lessc.inc.php#L2811

krnlde · 2013-06-05T11:45:01Z

...and further information regarding "named parameters", which might not be implemented in lessphp atm: less/less.js#268

aristath · 2013-06-05T12:52:00Z

@krnlde yeah, you're right...
I just came to the same conclusion.
Can you think of any workaround for this?
I'm considering altering the mixins.less file for my application...

krnlde · 2013-06-05T13:47:47Z

You would have to alter the implementation of the mixins aswell. For example in the https://github.com/twitter/bootstrap/blob/3.0.0-wip/less/dropdowns.less#L71. No solution for the future.

The lessphp compiler has to work the same as the less.js.

aristath · 2013-06-05T14:46:26Z

In case anyone's interested, I decided to fork Bootstrap and keep a lessphp-compatible version.
The above problem can be solved with this commit: https://github.com/aristath/bootstrap/commit/9b53072ddf77fa49013f4006fcd75a4857103753

krnlde · 2013-06-06T08:28:36Z

Thank you! Unfortunately this isn't the right move. The improvements in less.js absolutely make sense. And all further releases of Bootstrap will rely on them. Therefore lessphp should support them in longterm.

But for now I appreciate your fork very much :)

aristath · 2013-06-06T08:39:31Z

Yes, I agree. They do make sense and they do make writing less easier!
But I just can't wait for lessphp to be updated as this might take months and I need it now!
lessphp should support everything that less.js supports but that's not an easy task and while I try to understand how to update lessphp to support these and contribute back here, this fork will at least prevent my app from crashing. :)

krnlde · 2013-06-06T10:03:21Z

👍

GodOfGrandeur · 2013-06-07T13:34:32Z

I have a issue with Bootstrap 3 too. It falls into a infinite loop and can't compile it. Error is in: lessc.inc.php on line 1252.

aristath · 2013-06-07T13:38:08Z

Hello there @jaggi
Until lessphp is updated to support all the new features of less.js that were introduced in version 1.4 you 're free to use my mofied version of Bootstrap3 that compiles with phpless without any issues: https://github.com/aristath/bootstrap
I'll maintain it an update it on a daily basis as I need it for my app so it will always be in sync with bootstrap's changes.

GodOfGrandeur · 2013-06-12T10:19:20Z

@aristath thanks for the offer but for the time being I've changed to using recess which has a watch function so compiles each time I make changes. It allows me to get around any of the current issues until lessphp is updated.

dwightwatson · 2013-06-21T15:20:51Z

Is lessphp still in development; are we likely to see the changes required for Bootstrap 3 to be made?

aristath · 2013-06-21T15:24:17Z

@dwightwatson as mentioned above, feel free to use my branch of Bootstrap 3.0 until lessphp gets updated.
It's compatible and I had no issues using it so far.
I keep updating it daily, pulling commits from the official repo and checking for any incompatibilities.

dwightwatson · 2013-06-21T15:26:38Z

I understand, and I appreciate the offer. I might do that in the meantime for development, but am concerned about relying on lessphp for the future of my projects if it is no longer being developed/maintained.

aristath · 2013-06-21T15:30:34Z

As far as I know this prohect is properly maintained.
However less.js got updated recently and some of its improvements need a lot of work to get implemented in lessphp.
It might take some time, but it will happen. :)

sergiodlopes · 2013-07-12T14:02:06Z

@aristath still having the same issues with your fork in lessphp (reaching maximum function nesting level). Thanks for all the work thought :)

Can someone send me a compiled (css) version of bootstrap 3?

aristath · 2013-07-12T15:28:23Z

@sergiodlopes you can grab it pre-compiled from the docs: https://github.com/twitter/bootstrap/blob/3.0.0-wip/docs/assets/css/bootstrap.css

sergiodlopes · 2013-07-12T23:14:12Z

@aristath Thanks! :)

mapb1990 · 2013-07-29T23:21:08Z

+1

solispauwels · 2013-07-30T09:35:35Z

HELP!

ursbraem · 2013-08-02T14:35:36Z

yelp

kieste · 2013-08-02T18:26:14Z

+1 please fix it soon. THANX!!!

bjorn-ali-goransson · 2013-08-05T05:04:42Z

in lessc.inc.php:2793 (inside function argumentValues), you can change the following:

if (!$this->literal($delim)) break;

to

if (!$this->literal($delim) && !$this->literal(";")) break;

and you can now call mixins with either comma or semicolon. Ugly but what're we going to do.

But now there is another problem; named parameters like:

#gradient > .vertical(@start-color: @dropdown-link-hover-bg; @end-color: darken(@dropdown-link-hover-bg, 5%));

(dropdowns.less:76)

mrded · 2013-08-05T13:31:46Z

You can change less files, like follow.

.vertical(@start-color: #555; @start-percent: 0%; @end-color: #333; @end-percent: 100%) {}
to
.vertical(@start-color: #555, @start-percent: 0%, @end-color: #333, @end-percent: 100%) {}

#gradient > .vertical(@start-color: @dropdown-link-hover-bg; @end-color: darken(@dropdown-link-hover-bg, 5%));
to
#gradient > .vertical(@dropdown-link-hover-bg,, darken(@dropdown-link-hover-bg, 5%));

leafo · 2013-08-05T16:23:51Z

It's coming, just gonna take me some time because lessphp is quite behind.

solispauwels · 2013-08-06T09:43:50Z

master

petercoles · 2013-08-06T12:34:20Z

This 6-line project works fine for me.

composer.json

{
    "require": {
        "twitter/bootstrap": "dev-3.0.0-wip",
        "leafo/lessphp": "0.3.*@dev"
    }
}

index.php

<?php
require 'vendor/autoload.php';
$less = new lessc;
echo $less->compileFile("vendor/twitter/bootstrap/less/bootstrap.less");

I'd check that there's not something else in your environment getting in the way

swiftdv8 · 2013-10-17T16:58:27Z

UPDATE: Twitter bootstrap 3 no longer works if pulling master. The last working commit is 727a91de1c. So pull that commit for the time being to get it playing nice with lessphp. The breaking commit appears to be this one... 265fda7903 - hopefully mr leafo will have some ideas.

For anyone unsure how to get to that commit just clone bootstrap as normal and then create a branch from that commit:

git checkout -b working_lessphp 727a91de1c

andrewdelprete · 2013-10-17T17:43:01Z

I am also having problems with Bootstrap 3.0 release. I'm using Composer to install Lessphp and Bootstrap, would anyone know how I can pull from a commit that works via Composer?

petercoles · 2013-10-17T18:04:59Z

"leafo/lessphp": "0.4.0"

swiftdv8 · 2013-10-17T19:48:10Z

@Pathsofdesign

Peters right that you need the 4.0 release of lessphp but you will also need lock to the last working commit on bootstrap, something like this might work:

"require": {
"leafo/lessphp": "0.4.0",
"twitter/bootstrap": "dev-master#727a91de1c"
},

I dont use composer to install bootstrap and packagist seems to reference a different branch for composer install so Im not 100% on this.

petercoles · 2013-10-17T20:23:17Z

I may have interpreted @Pathsofdesign's reference to Bootstrap 3.0 a little too literally (i.e. to mean the 3.0.0 stable release).

However, for the benefit of anybody wanting to get as closer to the dev-master as possible, @dwall80's suggestion works.

andrewdelprete · 2013-10-17T20:31:47Z

@petercoles no problem, I wasn't real clear with my comment.

After utilizing Bootstrap's commit #727a91de1c and LessPHP 0.4.0, I started receiving this error on compile:

".pull-right is undefined: line: 60"

I had to roll with an earlier commit of LessPHP and Bootstrap to work via Composer.

"leafo/lessphp": "dev-master#85bd4557920d5f4fcbf41beb621e91b842e3621b",
"twitter/bootstrap": "dev-master#727a91de1c"

Solution found here: http://stackoverflow.com/questions/19059069/asseticdump-fails-with-pull-right-is-undefined-line-60/19061496#19061496

petercoles · 2013-10-18T13:38:14Z

That's strange as

"require": {
    "leafo/lessphp": "0.4.0",
    "twitter/bootstrap": "dev-master#727a91de1c"
}

and

"require": {
    "leafo/lessphp": "0.4.*@dev",
    "twitter/bootstrap": "dev-master#727a91de1c"
}

work fine for me.

swiftdv8 · 2013-10-18T14:31:56Z

@petercoles,"leafo/lessphp": "0.4.0" worked for me too when using plessc to compile from the command line but I got the same error as Pathsofdesign when trying to compile via basset (laravel asset manager package) - not sure if this is significant.
Using the two commits mentioned it all works fine through either.

tomsarduy · 2013-10-25T07:52:41Z

New: lessphp 0.4.0, compiles Bootstrap 3!!! see Changelog Thanks! :)

swiftdv8 · 2013-10-25T09:06:44Z

@tomsrduy Have you tried it? Because it said it did previously but at as written in the comments it doesn't compile past a certain breaking commit even with the latest release of lessphp.

krnlde · 2013-10-25T12:03:44Z

Doesn't work for me @tomsarduy. Working with twbs/bootstrap@a58c83a (currently latest)

It now sais: Failed to assign arg @list

pdias · 2013-10-27T18:35:18Z

Hello,

I have comment the:

Failed to assign arg @list

in #491

My solution (not a solution), just for work, was comment the throw.

Thanks.

ghost · 2013-11-03T19:44:26Z

Just comment the line brings another error:

Fatal error: Uncaught exception 'Exception' with message '.make-grid is undefined: path/less/bootstrap.less on line 50' in path/php/lessc.inc.php:3521

Stack trace:
0 path/php/lessc.inc.php(2063): lessc_parser->throwError('.make-grid is u...', 17931)
1 path/php/lessc.inc.php(720): lessc->throwError('.make-grid is u...')
2 path/php/lessc.inc.php(757): lessc->compileProp(Array, Object(stdClass), Object(stdClass))
3 path/php/lessc.inc.php(757): lessc->compileProp(Array, Object(stdClass), Object(stdClass))
4 path/php/lessc.inc.php(757 in path/php/lessc.inc.php on line 3521

pdias · 2013-11-04T10:06:59Z

Hello,

I use this in composer for leafo :

"leafo/lessphp": "dev-master#85bd4557920d5f4fcbf41beb621e91b842e3621b",

And just comment line 617 in lessc.inc.php works.

nickrouty · 2013-11-05T17:52:10Z

The following currently is working for me thanks to @dwall80

"require": {
        "leafo/lessphp": "0.4.0",
        "twitter/bootstrap": "dev-master#727a91de1c"
}

maubut · 2013-11-18T19:33:36Z

lessPHP failed to compile v3.0.2. Seem to be in grid.less..

mbrevda · 2013-11-19T10:17:02Z

+1

sstok · 2013-11-22T13:35:39Z

Seems to be caused by.
twbs/bootstrap@c814ad1#diff-5

This is the only file having @list

Full stack trace.

() at [...]/vendor/leafo/lessphp/lessc.inc.php:3462
lessc_parser->throwError() at [...]/vendor/leafo/lessphp/lessc.inc.php:2005
lessc->throwError() at [...]/vendor/leafo/lessphp/lessc.inc.php:617
lessc->zipSetArgs() at [...]/vendor/leafo/lessphp/lessc.inc.php:470
lessc->patternMatch() at [...]/vendor/leafo/lessphp/lessc.inc.php:553
lessc->patternMatchAll() at [...]/vendor/leafo/lessphp/lessc.inc.php:572
lessc->findBlocks() at [...]/vendor/leafo/lessphp/lessc.inc.php:684
lessc->compileProp() at [...]/vendor/leafo/lessphp/lessc.inc.php:725
lessc->compileProp() at [...]/vendor/leafo/lessphp/lessc.inc.php:162
lessc->compileImportedProps() at [...]/vendor/leafo/lessphp/lessc.inc.php:769
lessc->compileProp() at [...]/vendor/leafo/lessphp/lessc.inc.php:162
lessc->compileImportedProps() at [...]/vendor/leafo/lessphp/lessc.inc.php:769
lessc->compileProp() at [...]/vendor/leafo/lessphp/lessc.inc.php:284
lessc->compileProps() at [...]/vendor/leafo/lessphp/lessc.inc.php:278
lessc->compileRoot() at [...]/vendor/leafo/lessphp/lessc.inc.php:193
lessc->compileBlock() at [...]/vendor/leafo/lessphp/lessc.inc.php:1807
lessc->compile() at [...]/vendor/leafo/lessphp/lessc.inc.php:1934

krnlde · 2013-12-05T14:40:27Z

FYI https://github.com/cbekir/lessphp compiles the latest bootstrap dist.

afurculita · 2013-12-12T12:39:39Z

@krnlde it compiles, but with errors. For example, the widths for all the columns are not calculated.

krnlde · 2013-12-14T22:20:41Z

Oh OK! Thanks

nusphere · 2013-12-17T21:15:56Z

@krnlde thx to your fork
a working solution is to add the fork as repository

"repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:cbekir/lessphp.git"
        }
    ],

"require": {

        "twbs/bootstrap": "3.0.*",
        "leafo/lessphp": "dev-master"
    },

krnlde · 2013-12-18T10:49:55Z

Doesn't it have to be

...
"cbekir/lessphp": "dev-master"
...

hice3000 · 2013-12-19T14:07:21Z

@krnlde I don't think so as the composer.json's name tag is leafo/lessphp, too.

aristath · 2015-03-15T19:41:39Z

Closing this one.
It's been too long and to be honest I haven't checked it recently.
For all I know this may be working now... if needed I guess we can open up a new issue.

jallits mentioned this issue Jun 11, 2013

Mixin and class conflict #437

Closed

dakota mentioned this issue Jul 9, 2013

Update mixins.less twbs/bootstrap#8425

Closed

cvrebert mentioned this issue Aug 3, 2013

bootstrap 3 RC1 not compile #450

Closed

bjorn-ali-goransson mentioned this issue Aug 5, 2013

Allow named parameters, and semicolons as parameter delimiters #454

Closed

lahmizzar mentioned this issue Nov 12, 2013

lessPHP failed to compile BS3 v3.0.2 devxive/nawala-rdk#1

Open

NicolasBadey mentioned this issue Jan 9, 2014

Can Not install with bootstrap michelsalib/BCCCronManagerBundle#37

Closed

aristath closed this as completed Mar 15, 2015

Bootstrap 3 fails to compile #432

Bootstrap 3 fails to compile #432

Comments

aristath commented Jun 3, 2013

krnlde commented Jun 5, 2013

krnlde commented Jun 5, 2013

krnlde commented Jun 5, 2013

aristath commented Jun 5, 2013

krnlde commented Jun 5, 2013

aristath commented Jun 5, 2013

krnlde commented Jun 6, 2013

aristath commented Jun 6, 2013

krnlde commented Jun 6, 2013

GodOfGrandeur commented Jun 7, 2013

aristath commented Jun 7, 2013

GodOfGrandeur commented Jun 12, 2013

dwightwatson commented Jun 21, 2013

aristath commented Jun 21, 2013

dwightwatson commented Jun 21, 2013

aristath commented Jun 21, 2013

sergiodlopes commented Jul 12, 2013

aristath commented Jul 12, 2013

sergiodlopes commented Jul 12, 2013

mapb1990 commented Jul 29, 2013

solispauwels commented Jul 30, 2013

ursbraem commented Aug 2, 2013

kieste commented Aug 2, 2013

bjorn-ali-goransson commented Aug 5, 2013

mrded commented Aug 5, 2013

leafo commented Aug 5, 2013

solispauwels commented Aug 6, 2013

petercoles commented Aug 6, 2013

swiftdv8 commented Oct 17, 2013

andrewdelprete commented Oct 17, 2013

petercoles commented Oct 17, 2013

swiftdv8 commented Oct 17, 2013

petercoles commented Oct 17, 2013

andrewdelprete commented Oct 17, 2013

petercoles commented Oct 18, 2013

swiftdv8 commented Oct 18, 2013

tomsarduy commented Oct 25, 2013

swiftdv8 commented Oct 25, 2013

krnlde commented Oct 25, 2013

pdias commented Oct 27, 2013

ghost commented Nov 3, 2013

pdias commented Nov 4, 2013

nickrouty commented Nov 5, 2013

maubut commented Nov 18, 2013

mbrevda commented Nov 19, 2013

sstok commented Nov 22, 2013

krnlde commented Dec 5, 2013

afurculita commented Dec 12, 2013

krnlde commented Dec 14, 2013

nusphere commented Dec 17, 2013

krnlde commented Dec 18, 2013

hice3000 commented Dec 19, 2013

aristath commented Mar 15, 2015