Less Importer: Throw some notice when a file is skipped #3065
Conversation
|
Technically I'm not big fan of logging anything in a release build (at some point the logging code just starts to overweight the actual code... :) But I can't see any real reason why this can't be merged. @matthew-dean? |
|
Can this PR's merge conflicts be addressed? |
|
Sure, I can fix the conflicts if the team has any intention on merging this. Otherwise, I would prefer to just close it. :) EDIT: I just realized you're an owner on this repo @matthew-dean -- I'll try and resolve this for you in the next couple of days. |
…an see why it was skipped in the logs
hilts-vaughan
force-pushed
the
emit-optional-info
branch
from
6884400
to
69faf81
Compare
|
All fixed, one click merge available now. ;) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Hello bot! This is active; just waiting for a maintainer to look at it. |
seven-phases-max
changed the title
|
@hilts-vaughan Sorry about that! Didn't see you'd fixed the conflicts. |
|
Ohh hmm.... come to think of it, this needs to be merged into master. 3.x isn't active anymore. Can you do a PR on master? |
|
Yep! Cherry picking onto a branch there OK? |
This is handy when you're trying to scour your logs to figure out why a file was not being included. :)