Revised dependencies - switched all request presence with phin. #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanent
changed the title
|
I just remembered that phin supports only Node 8 LTS and newer currently; as a result I'll hold off on making this PR until April when Node 6 hits its end-of-life. (Release Schedule) This PR should be able to be resumed once Node 6 support is no longer desired by the less project, likely when Node 6 reaches its end-of-life this April. :) |
|
Ok, this is relevant again. Node 6 hit end-of-life in April of last year, if I remember correctly. Now all supported versions of Node are supported for this PR.
|
|
@ethanent Have you looked into what the check failures are about? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the phin library is used as part of the build process, and it's more lightweight than request. (This change was originally made in #3096.)
I think it'd be great to use phin in production at this point as it's proven to be stable for the build process, and it is much more lightweight than request.