Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace request with phin #3397

Closed
wants to merge 2 commits into from
Closed

Replace request with phin #3397

wants to merge 2 commits into from

Conversation

ethanent
Copy link

@ethanent ethanent commented Jun 4, 2019

Same reasoning as #3350, just updated code. 😋

@ethanent
Copy link
Author

ethanent commented Jun 4, 2019

CI tests failed in Travis CI Node versions 6 and 9, and passed on Travis CI using Node version 8. It seems that my commits weren't responsible for the failures, and all tests for Node versions 4, 6, 8, and 9 passed in AppVeyor. 👍

@matthew-dean
Copy link
Member

Can you update this with the latest code? Also, AFAIK, the dependency should be in optionalDependencies instead of dependencies

@stale
Copy link

stale bot commented Dec 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2019
@stale stale bot closed this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants